Skip to content

Comments

PDF viewer#5144

Draft
bram-maegerman wants to merge 3 commits intoDSpace:mainfrom
atmire:pdf-viewer-10.0.0-next
Draft

PDF viewer#5144
bram-maegerman wants to merge 3 commits intoDSpace:mainfrom
atmire:pdf-viewer-10.0.0-next

Conversation

@bram-maegerman
Copy link
Contributor

@bram-maegerman bram-maegerman commented Feb 20, 2026

References

Description

This PR adds a PDF viewer to DSpace

When enabled, users can view PDFs directly in the DSpace UI instead of downloading them. The viewer is based on ngx-extended-pdf-viewer.

Administrators can control PDF toggle the use of the viewer at community, collection, item, and bitstream levels. A new “PDF viewer” tab is added to the edit pages for communities, collections, and items, and a toggle is added to the edit bitstream page.

The file download link is updated so that when the PDF viewer is allowed, users see both a “View” (eye) and “Download” (file-download) icon instead of only a download link.

Instructions for Reviewers

To test the PDF viewer:

  1. Enable the PDF viewer for a bitstream by going to edit bitstream, and enabling the "Enable the PDF viewer for this bitstream" toggle
  2. Go to the item page, and click on the "eye" icon next to PDF bitstream on the simple item page.
  3. Verify the user get redirected to a separate page with a the PDF displayed.

List of changes in this PR:

  • Implemented a new PDF viewer based on ngx-extended-pdf-viewer.
  • Made the PDF viewer toggleable per DSO.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@bram-maegerman bram-maegerman mentioned this pull request Feb 20, 2026
10 tasks
@artlowel artlowel removed their request for review February 20, 2026 16:10
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

Integrated PDF viewer

2 participants