[DSpace-CRIS] Porting of authority based relations components#5134
Draft
FrancescoMolinaro wants to merge 4 commits intoDSpace:mainfrom
Draft
[DSpace-CRIS] Porting of authority based relations components#5134FrancescoMolinaro wants to merge 4 commits intoDSpace:mainfrom
FrancescoMolinaro wants to merge 4 commits intoDSpace:mainfrom
Conversation
…old module import
Member
|
@FrancescoMolinaro : Could you specify which DSpace-CRIS differences this PR relates to? I think it's important to be clear to reviewers which features or architectural changes are in each PR, and it's unclear to me which one(s) this references |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Relates to: DSpace/DSpace#11749
Relates to: Architectural difference #3
Description
Add new component for tabbed relations in item page.
The new relations are based on a scope parameter which represent the authority of the item in question.
Visually the component still uses the standard search page and is identical:
The new relations can be activated via a flag param in the default.app.config.ts, inside the item config:
showAuthorithyRelations
if true the ui components will use the new authority based relations.
Instructions for Reviewers
List of changes in this PR:
Add new UI component for new scope/authority based relations
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.