[DSpace-CRIS] porting of advanced attachment and canDownload authorization features changes#5132
Draft
FrancescoMolinaro wants to merge 40 commits intoDSpace:mainfrom
Draft
[DSpace-CRIS] porting of advanced attachment and canDownload authorization features changes#5132FrancescoMolinaro wants to merge 40 commits intoDSpace:mainfrom
FrancescoMolinaro wants to merge 40 commits intoDSpace:mainfrom
Conversation
Member
|
@FrancescoMolinaro : Same here, please specify in the PR description which DSpace-CRIS differences this PR implements/relates to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Relates to: DSpace/DSpace#11749
Relates to: Feature differences #12 and Feature differences #13
Description
Add new way of rendering download link in item page, the new UI component can be activated via the config:
showDownloadLinkAsAttachment
inside the layout config in default.app.config.ts.
The metadata to be visualized in the attachment box are handled with a separated config param:
advancedAttachmentRendering
Which allows granural control on which information to show in the template.
In addition a new route guard has been added for the bitstream download path, so that we can check the authorization before loading the page and handle in advance eventual authorizations needed.
On the rest side the canDownload authorization feature will be enhanced to allow authors the download of restricted items.
Instructions for Reviewers
The new config has been set as true for the time being so that every link in item page will be displayed with the new component.
The positioning was also adapted from the left side of the page to the right one, so to use the wider space for the additional informations.
List of changes in this PR:
Add new UI component and related configs
Add new guard for bitsream download path
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.