Skip to content

Comments

Discovery endpoints refactor#5131

Draft
alexandrevryghem wants to merge 3 commits intoDSpace:mainfrom
atmire:discovery-refactor-main
Draft

Discovery endpoints refactor#5131
alexandrevryghem wants to merge 3 commits intoDSpace:mainfrom
atmire:discovery-refactor-main

Conversation

@alexandrevryghem
Copy link
Member

References

Description

This PR updates the frontend to use the new endpoints from DSpace/DSpace#11966

Instructions for Reviewers

List of changes in this PR:

  • Removed the ConfigurationSearchPageComponent since this component doesn't have any custom logic. The only purpose of this component was to replace the SearchConfigurationService on the MyDSpace page, but we can also achieve this by allowing the SearchConfigurationService to be configured with an injection token on the SearchComponent. This will make the theming of the SearchComponent easier, because we won't be forced to theme the ConfigurationSearchPageComponent every time as well.
  • Created new services for the new endpoints & updated the model classes to reflect the returned response
  • ...

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem alexandrevryghem added this to the 10.0 milestone Feb 20, 2026
@alexandrevryghem alexandrevryghem self-assigned this Feb 20, 2026
@alexandrevryghem alexandrevryghem added component: Discovery related to discovery search or browse system merge conflict labels Feb 20, 2026
@alexandrevryghem alexandrevryghem marked this pull request as draft February 20, 2026 12:47
@alexandrevryghem alexandrevryghem moved this to 🏗 In Progress in DSpace 10.0 Release Feb 20, 2026
@tdonohue tdonohue moved this from 🏗 In Progress to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: Discovery related to discovery search or browse system merge conflict new feature

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

3 participants