Skip to content

Conversation

@jabrah
Copy link
Contributor

@jabrah jabrah commented Dec 9, 2025

References

Description

A recent change in DSpace 9.x explicitly added CommanderJS as a dependency because it has been used in various scripts for a long time, relying on it being present transitively. The specified version was

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • Update code documentation example to use NPM instead of Yarn
  • Update options handling for specified version of Commander.js
  • Adjust script error detection

You can test this locally in dspace-angular on by running the merge-i18n script using the custom theme provided.

npm run merge-i18n -- -s src/themes/custom/assets/i18n

Without this change, the script will always exit with an error about missing arguments.

  • If -s, or -d is invalid, you should be presented with an error message and the script's help text
  • If -d is not provided, it should use the default location: src/assets/i18n

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge labels Dec 10, 2025
@tdonohue tdonohue added the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Dec 10, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Dec 10, 2025
@nwoodward nwoodward self-requested a review December 11, 2025 15:39
@tdonohue tdonohue requested a review from artlowel December 11, 2025 15:40
Copy link
Member

@artlowel artlowel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jabrah!

The code looks good, and I can verify it fixes the issue!

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 10.0 Release Dec 11, 2025
@tdonohue tdonohue added this to the 10.0 milestone Dec 11, 2025
@tdonohue tdonohue merged commit 93b9b46 into DSpace:main Dec 11, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Dec 11, 2025
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-9_x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug high priority port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Broken 'merge-i18n' script

4 participants