[Port dspace-8_x] Prefetch rest responses

config/config.example.yml

@@ -550,3 +550,13 @@ liveRegion:
   messageTimeOutDurationMs: 30000
   # The visibility of the live region. Setting this to true is only useful for debugging purposes.
   isVisible: false
+
+
+# REST response prefetching configuration
+prefetch:
+  # The URLs for which the response will be prefetched
+  urls:
+    - /api
+    - /api/discover
+  # How often the responses are refreshed in milliseconds
+  refreshInterval: 60000

package.json

@@ -116,6 +116,7 @@
     "ngx-pagination": "6.0.3",
     "ngx-skeleton-loader": "^9.0.0",
     "ngx-ui-switch": "^14.1.0",
+    "node-html-parser": "^7.0.1",
     "nouislider": "^15.7.1",
     "pem": "1.14.8",
     "reflect-metadata": "^0.2.2",

server.ts

@@ -44,12 +44,13 @@ import { createProxyMiddleware } from 'http-proxy-middleware';
 import { hasValue } from './src/app/shared/empty.util';
 import { UIServerConfig } from './src/config/ui-server-config.interface';
 import bootstrap from './src/main.server';
-import { buildAppConfig } from './src/config/config.server';
+import { buildAppConfig, setupEndpointPrefetching } from './src/config/config.server';
 import {
   APP_CONFIG,
   AppConfig,
 } from './src/config/app-config.interface';
 import { extendEnvironmentWithAppConfig } from './src/config/config.util';
+import { ServerHashedFileMapping } from './src/modules/dynamic-hash/hashed-file-mapping.server';
 import { logStartupMessage } from './startup-message';
 import { TOKENITEM } from './src/app/core/auth/models/auth-token-info.model';
 import { CommonEngine } from '@angular/ssr';
@@ -70,7 +71,11 @@ const indexHtml = join(DIST_FOLDER, 'index.html');
 
 const cookieParser = require('cookie-parser');
 
-const appConfig: AppConfig = buildAppConfig(join(DIST_FOLDER, 'assets/config.json'));
+const destConfigPath = join(DIST_FOLDER, 'assets/config.json');
+const hashedFileMapping = new ServerHashedFileMapping(DIST_FOLDER, 'index.html');
+const appConfig: AppConfig = buildAppConfig(destConfigPath, hashedFileMapping);
+hashedFileMapping.addThemeStyles();
+hashedFileMapping.save();
 
 // cache of SSR pages for known bots, only enabled in production mode
 let botCache: LRU<string, any>;
@@ -247,7 +252,7 @@ function serverSideRender(req, res, next, sendToUser: boolean = true) {
   commonEngine
     .render({
       bootstrap,
-      documentFilePath: indexHtml,
+      documentFilePath: hashedFileMapping.resolve(indexHtml),
       inlineCriticalCss: environment.ssr.inlineCriticalCss,
       url: `${protocol}://${headers.host}${originalUrl}`,
       publicPath: DIST_FOLDER,
@@ -309,7 +314,7 @@ function serverSideRender(req, res, next, sendToUser: boolean = true) {
  * @param res current response
  */
 function clientSideRender(req, res) {
-  res.sendFile(indexHtml);
+  res.sendFile(hashedFileMapping.resolve(indexHtml));
 }
 
 
@@ -537,7 +542,7 @@ function serverStarted() {
  * Create an HTTPS server with the configured port and host
  * @param keys SSL credentials
  */
-function createHttpsServer(keys) {
+function createHttpsServer(prefetchRefreshTimeout: NodeJS.Timeout, keys) {
   const listener = createServer({
     key: keys.serviceKey,
     cert: keys.certificate,
@@ -550,7 +555,7 @@ function createHttpsServer(keys) {
   process.on('SIGINT', () => {
     void (async ()=> {
       console.debug('Closing HTTPS server on signal');
-      await terminator.terminate().catch(e => { console.error(e); });
+      clearTimeout(prefetchRefreshTimeout);await terminator.terminate().catch(e => { console.error(e); });
       console.debug('HTTPS server closed');
     })();
   });
@@ -559,7 +564,7 @@ function createHttpsServer(keys) {
 /**
  * Create an HTTP server with the configured port and host.
  */
-function run() {
+function run(prefetchRefreshTimeout: NodeJS.Timeout) {
   const port = environment.ui.port || 4000;
   const host = environment.ui.host || '/';
 
@@ -574,13 +579,16 @@ function run() {
   process.on('SIGINT', () => {
     void (async () => {
       console.debug('Closing HTTP server on signal');
-      await terminator.terminate().catch(e => { console.error(e); });
-      console.debug('HTTP server closed.');return undefined;
+      clearTimeout(prefetchRefreshTimeout);
+      await terminator.terminate().catch(e => {
+        console.error(e);
+      });
+      console.debug('HTTP server closed.');
     })();
   });
 }
 
-function start() {
+function start(prefetchRefreshTimeout: NodeJS.Timeout) {
   logStartupMessage(environment);
 
   /*
@@ -606,10 +614,11 @@ function start() {
     }
 
     if (serviceKey && certificate) {
-      createHttpsServer({
-        serviceKey: serviceKey,
-        certificate: certificate,
-      });
+      createHttpsServer(prefetchRefreshTimeout,
+        {
+          serviceKey: serviceKey,
+          certificate: certificate,
+        });
     } else {
       console.warn('Disabling certificate validation and proceeding with a self-signed certificate. If this is a production server, it is recommended that you configure a valid certificate instead.');
 
@@ -619,11 +628,11 @@ function start() {
         days: 1,
         selfSigned: true,
       }, (error, keys) => {
-        createHttpsServer(keys);
+        createHttpsServer(prefetchRefreshTimeout, keys);
       });
     }
   } else {
-    run();
+    run(prefetchRefreshTimeout);
   }
 }
 
@@ -648,8 +657,12 @@ function healthCheck(req, res) {
 declare const __non_webpack_require__: NodeRequire;
 const mainModule = __non_webpack_require__.main;
 const moduleFilename = (mainModule && mainModule.filename) || '';
-if (moduleFilename === __filename || moduleFilename.includes('iisnode')) {
-  start();
-}
+setupEndpointPrefetching(appConfig, destConfigPath, environment, hashedFileMapping).then(prefetchRefreshTimeout => {
+  if (moduleFilename === __filename || moduleFilename.includes('iisnode')) {
+    start(prefetchRefreshTimeout);
+  }
+}).catch((error) => {
+  console.error('Errored while prefetching Endpoint Maps', error);
+});
 
 export * from './src/main.server';

src/app/admin/admin-reports/filtered-collections/filtered-collections.component.spec.ts

@@ -19,6 +19,8 @@ import { DspaceRestService } from 'src/app/core/dspace-rest/dspace-rest.service'
 import { RawRestResponse } from 'src/app/core/dspace-rest/raw-rest-response.model';
 import { TranslateLoaderMock } from 'src/app/shared/mocks/translate-loader.mock';
 
+import { APP_CONFIG } from '../../../../config/app-config.interface';
+import { environment } from '../../../../environments/environment.test';
 import { FilteredCollectionsComponent } from './filtered-collections.component';
 
 describe('FiltersComponent', () => {
@@ -53,6 +55,7 @@ describe('FiltersComponent', () => {
       providers: [
         FormBuilder,
         DspaceRestService,
+        { provide: APP_CONFIG, useValue: environment },
       ],
       schemas: [NO_ERRORS_SCHEMA],
     });

src/app/app.config.ts

@@ -36,6 +36,8 @@ import {
 } from '../config/app-config.interface';
 import { StoreDevModules } from '../config/store/devtools';
 import { environment } from '../environments/environment';
+import { HashedFileMapping } from '../modules/dynamic-hash/hashed-file-mapping';
+import { BrowserHashedFileMapping } from '../modules/dynamic-hash/hashed-file-mapping.browser';
 import { EagerThemesModule } from '../themes/eager-themes.module';
 import { appEffects } from './app.effects';
 import {
@@ -154,6 +156,10 @@ export const commonAppConfig: ApplicationConfig = {
       useClass: DspaceRestInterceptor,
       multi: true,
     },
+    {
+      provide: HashedFileMapping,
+      useClass: BrowserHashedFileMapping,
+    },
     // register the dynamic matcher used by form. MUST be provided by the app module
     ...DYNAMIC_MATCHER_PROVIDERS,
     provideCore(),

src/app/core/auth/auth.interceptor.spec.ts

@@ -7,7 +7,9 @@ import { TestBed } from '@angular/core/testing';
 import { Router } from '@angular/router';
 import { Store } from '@ngrx/store';
 import { of as observableOf } from 'rxjs';
+import { environment } from 'src/environments/environment.test';
 
+import { APP_CONFIG } from '../../../config/app-config.interface';
 import { AuthServiceStub } from '../../shared/testing/auth-service.stub';
 import { RouterStub } from '../../shared/testing/router.stub';
 import { TruncatablesState } from '../../shared/truncatable/truncatable.reducer';
@@ -39,6 +41,7 @@ describe(`AuthInterceptor`, () => {
           multi: true,
         },
         { provide: Store, useValue: store },
+        { provide: APP_CONFIG, useValue: environment },
       ],
     });
 

src/app/core/browse/browse-definition-data.service.ts

@@ -1,16 +1,7 @@
 // eslint-disable-next-line max-classes-per-file
 import { Injectable } from '@angular/core';
-import {
-  Observable,
-  of as observableOf,
-} from 'rxjs';
-import { take } from 'rxjs/operators';
+import { Observable } from 'rxjs';
 
-import {
-  hasValue,
-  isNotEmpty,
-  isNotEmptyOperator,
-} from '../../shared/empty.util';
 import { FollowLinkConfig } from '../../shared/utils/follow-link-config.model';
 import { RemoteDataBuildService } from '../cache/builders/remote-data-build.service';
 import { RequestParam } from '../cache/models/request-param.model';
@@ -27,55 +18,18 @@ import {
 import { FindListOptions } from '../data/find-list-options.model';
 import { PaginatedList } from '../data/paginated-list.model';
 import { RemoteData } from '../data/remote-data';
-import { BrowseDefinitionRestRequest } from '../data/request.models';
 import { RequestService } from '../data/request.service';
 import { BrowseDefinition } from '../shared/browse-definition.model';
 import { HALEndpointService } from '../shared/hal-endpoint.service';
 
-/**
- * Create a GET request for the given href, and send it.
- * Use a GET request specific for BrowseDefinitions.
- */
-export const createAndSendBrowseDefinitionGetRequest = (requestService: RequestService,
-  responseMsToLive: number,
-  href$: string | Observable<string>,
-  useCachedVersionIfAvailable: boolean = true): void => {
-  if (isNotEmpty(href$)) {
-    if (typeof href$ === 'string') {
-      href$ = observableOf(href$);
-    }
-
-    href$.pipe(
-      isNotEmptyOperator(),
-      take(1),
-    ).subscribe((href: string) => {
-      const requestId = requestService.generateRequestId();
-      const request = new BrowseDefinitionRestRequest(requestId, href);
-      if (hasValue(responseMsToLive)) {
-        request.responseMsToLive = responseMsToLive;
-      }
-      requestService.send(request, useCachedVersionIfAvailable);
-    });
-  }
-};
-
-/**
- * Custom extension of {@link FindAllDataImpl} to be able to send BrowseDefinitionRestRequests
- */
-class BrowseDefinitionFindAllDataImpl extends FindAllDataImpl<BrowseDefinition> {
-  createAndSendGetRequest(href$: string | Observable<string>, useCachedVersionIfAvailable: boolean = true) {
-    createAndSendBrowseDefinitionGetRequest(this.requestService, this.responseMsToLive, href$, useCachedVersionIfAvailable);
-  }
-}
-
 /**
  * Data service responsible for retrieving browse definitions from the REST server
  */
 @Injectable({
   providedIn: 'root',
 })
 export class BrowseDefinitionDataService extends IdentifiableDataService<BrowseDefinition> implements FindAllData<BrowseDefinition>, SearchData<BrowseDefinition> {
-  private findAllData: BrowseDefinitionFindAllDataImpl;
+  private findAllData: FindAllData<BrowseDefinition>;
   private searchData: SearchDataImpl<BrowseDefinition>;
 
   constructor(
@@ -86,7 +40,7 @@ export class BrowseDefinitionDataService extends IdentifiableDataService<BrowseD
   ) {
     super('browses', requestService, rdbService, objectCache, halService);
     this.searchData = new SearchDataImpl(this.linkPath, requestService, rdbService, objectCache, halService, this.responseMsToLive);
-    this.findAllData = new BrowseDefinitionFindAllDataImpl(this.linkPath, requestService, rdbService, objectCache, halService, this.responseMsToLive);
+    this.findAllData = new FindAllDataImpl(this.linkPath, requestService, rdbService, objectCache, halService, this.responseMsToLive);
   }
 
   /**
@@ -171,9 +125,5 @@ export class BrowseDefinitionDataService extends IdentifiableDataService<BrowseD
       ...linksToFollow,
     );
   }
-
-  createAndSendGetRequest(href$: string | Observable<string>, useCachedVersionIfAvailable: boolean = true) {
-    createAndSendBrowseDefinitionGetRequest(this.requestService, this.responseMsToLive, href$, useCachedVersionIfAvailable);
-  }
 }
 

src/app/core/cache/builders/build-decorators.ts

@@ -36,15 +36,51 @@
  * @param target the typed class to map
  */
 export function typedObject(target: TypedObject) {
-  typeMap.set(target.type.value, target);
+  typeMap.set(target.type.value, new Map([[null, target]]));
+}
+
+/**
+ * Decorator function to map a ResourceType and sub-type to its class
+ */
+export function typedObjectWithSubType(subTypeProperty: string) {
+  return function(target: TypedObject) {
+    if (hasNoValue(target[subTypeProperty]?.value)) {
+      throw new Error(`Class ${(target as any).name} has no static property '${subTypeProperty}' to define as the sub-type`);
+    }
+
+    if (!typeMap.has(target.type.value)) {
+      typeMap.set(target.type.value, new Map());
+    }
+    if (!typeMap.get(target.type.value).has(subTypeProperty)) {
+      typeMap.get(target.type.value)
+        .set(subTypeProperty, new Map());
+    }
+
+    typeMap.get(target.type.value)
+      .get(subTypeProperty)
+      .set(target[subTypeProperty].value, target);
+  };
 }
 
 /**
  * Returns the mapped class for the given type
- * @param type The resource type
  */
-export function getClassForType(type: string | ResourceType) {
-  return typeMap.get(getResourceTypeValueFor(type));
+export function getClassForObject(obj: any) {
+  const map = typeMap.get(getResourceTypeValueFor(obj.type));
+
+  if (hasValue(map)) {
+    for (const subTypeProperty of map.keys()) {
+      if (subTypeProperty === null) {
+        // Regular class without subtype
+        return map.get(subTypeProperty);
+      } else if (hasValue(obj?.[subTypeProperty])) {
+        // Class with subtype
+        return map.get(subTypeProperty).get(getResourceTypeValueFor(obj?.[subTypeProperty]));
+      }
+    }
+  }
+
+  return undefined;
 }
 
 /**

src/app/core/cache/builders/remote-data-build.service.ts

@@ -47,7 +47,7 @@ import {
 } from '../../shared/request.operators';
 import { getResourceTypeValueFor } from '../object-cache.reducer';
 import { ObjectCacheService } from '../object-cache.service';
-import { getClassForType } from './build-decorators';
+import { getClassForObject } from './build-decorators';
 import { LinkService } from './link.service';
 
 @Injectable({ providedIn: 'root' })
@@ -113,7 +113,7 @@ export class RemoteDataBuildService {
    * @param obj  The object to turn in to a class instance based on its type property
    */
   private plainObjectToInstance<T>(obj: any): T {
-    const type: GenericConstructor<T> = getClassForType(obj.type);
+    const type: GenericConstructor<T> = getClassForObject(obj);
     if (typeof type === 'function') {
       return Object.assign(new type(), obj) as T;
     } else {