Return no content for unset properties #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks @J4bbi ! This looks correct & is just a documentation mistake. Merging immediately. |
tdonohue
approved these changes
Oct 25, 2023
Member
|
@J4bbi : I've reverted this PR. So, please feel free to recreate it and link it up to DSpace/DSpace#9014 Apologies for the misunderstanding. |
Member
|
@J4bbi : I will also note though that I'm starting to wonder if the better "fix" here is to simply use the newly built The behavior of returning a 404 no longer is a problem if properties are changed to be loaded in bulk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.