Skip to content

Conversation

@ehinman
Copy link
Collaborator

@ehinman ehinman commented Nov 26, 2025

Adding nldi module to __init__.py was a mistake: it causes dataretrieval to try to import the nldi module (which uses the optional dependency geopandas) every time dataretrieval or any of its modules are imported. This will throw an error if you try to install dataretrieval in an environment that does not also have geopandas. My bad. This PR fixes this issue. User can still use from dataretrieval import nldi or similar to use the module (if they also have geopandas).

@ehinman ehinman requested a review from thodson-usgs November 26, 2025 19:31
@thodson-usgs thodson-usgs merged commit 8f37748 into DOI-USGS:main Nov 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants