Remove qwdata documentation, tests, etc. and replace with waterdata.get_samples() #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
You don't think we're ready to move |
ehinman
changed the title
Collaborator
Author
Following our discussion today, I have moved |
Collaborator
Author
|
@thodson-usgs this is ready for review. |
thodson-usgs
approved these changes
Jun 23, 2025
Collaborator
thodson-usgs
left a comment
thodson-usgs
left a comment
There was a problem hiding this comment.
Looks good, just ensure your tests path with any accepted changes.
dataretrieval/nwis.py
Outdated
| **kwargs, | ||
| ) | ||
| return df | ||
| return print("qw data are no longer available from" \ |
Collaborator
There was a problem hiding this comment.
Raise an exception here. Something like:
raise ValueError(
"qwdata endpoint was decomissioned.",
"Please use `samples.get_usgs_samples()` instead."
)
Collaborator
Author
There was a problem hiding this comment.
Removed as an option for a service. Put back in?
Co-authored-by: Timothy Hodson <34148978+thodson-usgs@users.noreply.github.com>
Co-authored-by: Timothy Hodson <34148978+thodson-usgs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates documentation to refer to
waterdata.get_samples()rather thannwis.get_qwdata.