Skip to content

Conversation

@jwillemsen
Copy link
Member

@jwillemsen jwillemsen commented Jan 12, 2026

* .github/workflows/macosx.yml:

Summary by CodeRabbit

  • Chores
    • Updated CI workflow configuration to streamline the build matrix for macOS environments.

No changes visible to end-users.

✏️ Tip: You can customize this high-level summary in your review settings.

    * .github/workflows/macosx.yml:
@coderabbitai
Copy link

coderabbitai bot commented Jan 12, 2026

Walkthrough

The macOS CI workflow has been narrowed to remove macOS 13 from the build matrix, retaining only macOS 14. This reduces the number of concurrent CI builds without modifying any workflow logic or steps.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
.github/workflows/macosx.yml
Removed macOS 13 from build matrix; CI pipeline now targets macOS 14 exclusively

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 One version gone, the matrix shrinks,
macOS 14 alone now links,
Fewer builds, same rabbit speed,
Streamlined CI is all we need! 🚀

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly summarizes the main change: removing macOS 13 from the CI matrix because runners are deprecated at GitHub, which matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/macosx.yml (1)

19-26: LGTM! Removal of deprecated macos-13 runner is correct.

The macOS 13 runner image was retired by December 4th, 2025, and the images are now fully unsupported. GitHub Actions started the deprecation process for macOS 13 and macOS 13 arm64.

Migrating to macos-14 is a valid approach. As an optional enhancement, you might consider expanding the matrix to include macos-15 (or macos-latest) to ensure broader compatibility testing, since workflows that are architecture agnostic are encouraged to transition to arm64 labels such as macos-15, macos-latest, or macos-14.

💡 Optional: Expand matrix to include macos-15
     strategy:
       matrix:
         cxxstd: ["17"]
-        os: [macos-14]
+        os: [macos-14, macos-15]
         include:
           - platform_file: include $(ACE_ROOT)/include/makeinclude/platform_macosx.GNU
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 681ce3d and 1db307f.

📒 Files selected for processing (1)
  • .github/workflows/macosx.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: macos-14-C++17
  • GitHub Check: VS2022Debug64
  • GitHub Check: windows-2022 vs2022
  • GitHub Check: ubuntu-24.04 g++-10
  • GitHub Check: VS2022Release32
  • GitHub Check: Codacy Static Code Analysis

@jwillemsen jwillemsen merged commit 27bdde9 into DOCGroup:master Jan 12, 2026
11 checks passed
@jwillemsen jwillemsen deleted the jwi-depmacos13 branch January 12, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant