Skip to content

Conversation

@johanix
Copy link
Contributor

@johanix johanix commented Nov 13, 2022

Not ready for commit, but I'd appreciate feedback on this change.

  • It removes a ton of error returns from all over the music/*ops.go code
  • It is based on the observation that transactions can only be initiated by either a request via apiserver or by a mdb.PushZone() from fsmengine. So let's create the transactions there only and remove all that cruft from the rest of the code.
  • Happiness is a negative diff :-)

Note that this is only briefly tested at this stage. Although the fix is simple in theory, it is quite large, so it really requires more testing.

Johan

  NOTE however, that while this should be a straight forward restructuring
  it is not yet much tested.
@johanix johanix marked this pull request as draft November 14, 2022 09:24
@johanix johanix changed the title For your consideration: Transaction fix WIP: For your consideration: Transaction fix Nov 17, 2022
@johanix johanix marked this pull request as ready for review November 19, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants