Improvement: clang compliance #2088
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes here:
We are currently trying to update the t8code Julia bindings https://github.com/DLR-AMR/T8code.jl to version 4. The first step is to ensure t8code successfully compiles using the official Julia BinaryBuilder workflow, which by default is run on several platforms.
Our first attempt was successful on linux: JuliaPackaging/Yggdrasil#12756
We are now trying to make it work on macos as well: JuliaPackaging/Yggdrasil#12925
It seems adding the include statement as proposed in this PR makes t8code compile successfully using clang.
(We also observed some warnings regarding
%lliformat specifiers, but this has apparently already fixed in 021468c)All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).