-
Notifications
You must be signed in to change notification settings - Fork 63
Improvement: Update timeouts in testsuite #2086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
10min are very generous here. It usually takes only a couple of secons.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2086 +/- ##
=======================================
Coverage 77.05% 77.05%
=======================================
Files 112 112
Lines 18959 18959
=======================================
Hits 14608 14608
Misses 4351 4351 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| jobs: | ||
| t8code_cmake_tests: | ||
| timeout-minutes: 60 | ||
| timeout-minutes: 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The normal runtime seems to be less than 10 minutes, so 20 minutes would still be two times as long
| timeout-minutes: 30 | |
| timeout-minutes: 20 |
| jobs: | ||
| t8code_cmake_tests: | ||
| timeout-minutes: 60 | ||
| timeout-minutes: 15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The normal runtime seems to be less than 10 minutes, but i think if a runner has a hiccup it could maybe need more than 5 minutes longer without us being at fault
| timeout-minutes: 15 | |
| timeout-minutes: 20 |
| jobs: | ||
| t8code_cmake_tests: | ||
| timeout-minutes: 60 | ||
| timeout-minutes: 15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
| timeout-minutes: 15 | |
| timeout-minutes: 20 |
Closes #2087
After improving the runtime of our testsuite we have not updated the timeouts.
This PR sets appropiate timeouts for every workflow.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).