Skip to content

Conversation

@lenaploetzke
Copy link
Collaborator

@lenaploetzke lenaploetzke commented Jan 13, 2026

Closes #2081

Describe your changes here:
Using #pragma once is now tested in the mesh handle and as decided in the dev meeting, structs are used instead of classes.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.46%. Comparing base (4665876) to head (04618cc).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2080   +/-   ##
=======================================
  Coverage   77.46%   77.46%           
=======================================
  Files         112      112           
  Lines       19084    19084           
=======================================
  Hits        14784    14784           
  Misses       4300     4300           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lenaploetzke lenaploetzke requested a review from spenke91 January 13, 2026 11:31
Base automatically changed from handle-neighbor-and-ghost to main January 14, 2026 15:07
spenke91
spenke91 previously approved these changes Jan 16, 2026
Copy link
Collaborator

@spenke91 spenke91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me. However, I do have one minor(st) concern you may address or ignore:

I feel like mesh_type and in particular element_type sound somewhat misleading, in that it sounds like they may also just be some integer or something that indicates the type of the element. Do you know what I mean? It's probably not a problem, though 🤔

@spenke91 spenke91 assigned lenaploetzke and unassigned spenke91 Jan 16, 2026
Copy link
Collaborator

@spenke91 spenke91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lenaploetzke lenaploetzke added this pull request to the merge queue Jan 16, 2026
Merged via the queue into main with commit ad2de80 Jan 16, 2026
39 checks passed
@lenaploetzke lenaploetzke deleted the pragma-struct-and-more-functionality branch January 16, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement: Use pragma once in mesh handle and struct instead of class

3 participants