-
Notifications
You must be signed in to change notification settings - Fork 7
Update to t8code v4.0.0 #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fixes.sh not run yet!
move everything to ignore to generator.toml, try to keep manual fixes list short
|
Meanwhile, JuliaPackaging/Yggdrasil#12756 has been merged, i.e. we have binary packages here: https://github.com/JuliaBinaryWrappers/t8code_jll.jl We now face the following issues:
At least, Linux, x64, with Julia >= 1.9, runs at the moment and could be used to update downstream packages. |
|
Nice work! I cannot say anything about point 1 and 4 |
|
Regarding 4: I think it would be fine to bump the minimal julia version for T8code.jl to v1.10 (and run CI on it) especially because Trixi.jl already has v1.10 as minimum required and it is the current LTS. |
|
Thanks for your feedback! Dropping support for all problematic platforms would be the easiest option and as a Trixi.jl person I would not be afraid to do so. I was just a little reluctant because of potential further downstream packages. |
generator.jl, based on include files from buildkite runs in [T8code] update to version 4 JuliaPackaging/Yggdrasil#12756.fixed.shwas cleaned up