-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/use uv #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature/use uv #16
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2e41a7c
Swap to using UV
DJSaunders1997 2198ea0
Update fastapi docs
DJSaunders1997 7ce5f53
change default to gemini 2
DJSaunders1997 5dd52ee
Enhance FastAPI backend with detailed API documentation and logging; …
DJSaunders1997 01daf15
change to ues api keys
DJSaunders1997 a23e32c
More advanced pytesting
DJSaunders1997 1523333
Remove broken models
DJSaunders1997 0c840b1
Make model list dynamic
DJSaunders1997 da9d731
ruff format and fix
DJSaunders1997 e790519
More ruff stuff
DJSaunders1997 8f14186
dont run integration tests
DJSaunders1997 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review Feedback:
Shell Commands Safety: Running
curl ... | shdirectly can be risky unless the source is entirely trusted. Consider downloading and inspecting the contents of the script before executing it.Efficiency Improvement: Instead of sourcing
$HOME/.cargo/envrepeatedly, consider sourcing it once at the beginning or manage the environment variables in a single place.Consistency: Ensure consistent formatting and handling within each step for better readability and maintainability.
Dependency Syncing: Ensure that syncing dependencies with
uv syncis well managed and satisfies all project requirements adequately.Testing Environment Awareness: Verify that the testing environment and setup are robust to avoid false negatives or positives within test results.
Code Paths & Mapping: Confirm that paths are correctly set and correspond to the expected file locations for operations like linting and running tests.
Integrating Comments: Consider adding comments to explain complex or critical steps to improve the code's understandability for future maintainers or collaborators.
Error Handling: Implement error handling where necessary, especially for critical steps like dependency installation, linting, and testing phases.
Security Checks: Include security checks where relevant to ensure sensitive information does not leak during any part of the process.
Version Control: Be wary of hardcoded versions in commands to ensure compatibility over time; prefer using version constraints in your project configuration.
Bug Risks:
Overall Improvement Suggestions:
With these adjustments, you can make the CI/CD process more robust and reliable while decreasing potential vulnerabilities and enhancing code quality.