-
Notifications
You must be signed in to change notification settings - Fork 184
[9.0] fix: JobWrapper does not manage to send job parameters #8399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: integration
Are you sure you want to change the base?
Conversation
| self.pilotRef = gConfig.getValue("/LocalSite/PilotReference", "Unknown") | ||
| self.cpuNormalizationFactor = gConfig.getValue("/LocalSite/CPUNormalizationFactor", 0.0) | ||
| self.bufferLimit = gConfig.getValue(self.section + "/BufferLimit", 10485760) | ||
| logLevel = gConfig.getValue(self.section + "/LogLevel", "VERBOSE") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "VERBOSE" already the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, it sounds like we can actually modify the LogLevel of the JobWrapper by either:
- changing the log level in the JDL of a given job
- or changing the log level of the
JobAgent
I will give it a try
b205740 to
f662c62
Compare
|
After installing the branch in certification, I managed to investigate the issue properly and set up a reproducer.
The |
|
I made a fix that I need to test properly in the certification machine again just to make sure it was the only problem. |
7e93406 to
661efed
Compare
| for key in ceOptions: | ||
| if key in INTEGER_PARAMETERS: | ||
| ceOptions[key] = int(ceOptions[key]) | ||
| ceOptions[key] = int(float(ceOptions[key])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In DIRACGrid/diracx#653 we said that CPUNormalizationFactor should be treated as a float.
I still process it as an int here, because I would also need to modify diracx and OS before adding it to FLOAT_PARAMETERS.
Once merged I will open an issue to keep track of it of course.
c3a13b6 to
4e63611
Compare
4e63611 to
635ab15
Compare
|
Tested and fixed in certification: you can have a look to the job parameters of job |
While trying to debug the issue we have with job parameters, I noticed we didn't have any way (or at least any obvious way) to change the log level of the job wrapper (
INFOby default from what I can see).BEGINRELEASENOTES
*WorkloadManagement
NEW: ability to adjust job wrapper log level
ENDRELEASENOTES