Open
Conversation
| Description("Returns lat,lon for given hex."). | ||
| Param(bloblang.NewStringParam("hex_id")) | ||
|
|
||
| err = bloblang.RegisterFunctionV2("h3_hex_to_geo", hexLatLonSpec, func(args *bloblang.ParsedParams) (bloblang.Function, error) { |
Contributor
There was a problem hiding this comment.
Cool staff overall!!! Nit - extracting those anonymous functions to separate ones for readability might be good.
KevinJoiner
suggested changes
May 7, 2024
Contributor
KevinJoiner
left a comment
KevinJoiner
left a comment
There was a problem hiding this comment.
I think you need to run go mod tidy and your tests lat and long have a rounding error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functions:
h3_lat_lng_to_hex(lat,lon,resolution) -> hexId: string
h3_hex_to_geo(hexId) -> lat:float64, lng: float64
h3_valid_hex(hexId) -> boolean
h3_get_resolution(hexId) -> integer(0-15)
h3_hex_parent_id(hexId,resolution) -> hexId: string
h3_hex_parent_to_geo(hexId, resolution) -> lat:float64, lng: float64