Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughUpdates GitHub Actions npm config handling, converts a Flow conference page from raw HTML/CSS to Quarto/Markdown, adds Flow Conference presentation styles to the main stylesheet, and applies minor formatting changes to license and documentation files. Changes
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
.github/workflows/quarto-publish.yml (1)
21-22: Remove commented-out workflow config.Lines 21-22 keep obsolete config as comments, which adds noise in CI files. Prefer deleting these lines now that the temp
.npmrcflow is in place.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/quarto-publish.yml around lines 21 - 22, Remove the obsolete commented-out env configuration by deleting the two commented lines that reference NPM_CONFIG_USERCONFIG and ${{ runner.temp }}/.npmrc (the commented "env:" block and the "NPM_CONFIG_USERCONFIG" line) from the workflow file so the CI config is clean and no longer contains the unused temp .npmrc comment.styles.css (1)
235-239: Add keyboard focus styling parity for partner logos.Lines 235-239 style hover states, but keyboard focus is not covered. Add
:focus-visiblefor accessibility consistency.Suggested patch
- .partner-logos a:hover img, - .partner-logos img:hover { + .partner-logos a:hover img, + .partner-logos a:focus-visible img, + .partner-logos img:hover { filter: grayscale(0%); opacity: 1; }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@styles.css` around lines 235 - 239, The hover-only rule for partner logos (selectors .partner-logos a:hover img and .partner-logos img:hover) misses keyboard focus; update the stylesheet to include matching :focus-visible states so keyboard users get the same grayscale and opacity changes (e.g., add .partner-logos a:focus-visible img and .partner-logos img:focus-visible alongside the existing hover selectors) ensuring the same filter: grayscale(0%) and opacity: 1 are applied.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@content/projects/flow/20260511-flow-conference/index.qmd`:
- Around line 35-38: The CTA links inside the .flow-cta-row are rendered as
plain links so the intended styles aren't applied; update the two link elements
inside the ::: {.flow-cta-row} block to include the CSS class names used by the
stylesheet (e.g., add class="flow-cta" to the primary "View program" link and
class="flow-cta-secondary" to the "Partners" link) so the .flow-cta and
.flow-cta-secondary styles take effect.
- Around line 85-107: The two schedule Markdown tables inside the ":::
{.program-day}" blocks (the morning/Thursday table and the Friday table) are
missing the .program-table class so the styles in styles.css won't apply; add
the .program-table class to each table by attaching the attribute to the table
markup (e.g., ensure the Thursday table and the Friday table both carry
{.program-table}) so the new schedule table styles are applied consistently.
---
Nitpick comments:
In @.github/workflows/quarto-publish.yml:
- Around line 21-22: Remove the obsolete commented-out env configuration by
deleting the two commented lines that reference NPM_CONFIG_USERCONFIG and ${{
runner.temp }}/.npmrc (the commented "env:" block and the
"NPM_CONFIG_USERCONFIG" line) from the workflow file so the CI config is clean
and no longer contains the unused temp .npmrc comment.
In `@styles.css`:
- Around line 235-239: The hover-only rule for partner logos (selectors
.partner-logos a:hover img and .partner-logos img:hover) misses keyboard focus;
update the stylesheet to include matching :focus-visible states so keyboard
users get the same grayscale and opacity changes (e.g., add .partner-logos
a:focus-visible img and .partner-logos img:focus-visible alongside the existing
hover selectors) ensuring the same filter: grayscale(0%) and opacity: 1 are
applied.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
content/posts/20260226-dhd-poster/benasch_poster_dhd.jpgis excluded by!**/*.jpgcontent/posts/20260226-dhd-poster/benasch_poster_dhd_preview.jpgis excluded by!**/*.jpg
📒 Files selected for processing (3)
.github/workflows/quarto-publish.ymlcontent/projects/flow/20260511-flow-conference/index.qmdstyles.css
Comment on lines
+35
to
+38
| ::: {.flow-cta-row} | ||
| [View program](#conference-program) | ||
| [Partners](#partners-and-supporters) | ||
| ::: |
Contributor
There was a problem hiding this comment.
CTA links are missing the classes targeted by CSS.
Lines 35-38 render plain links, so .flow-cta / .flow-cta-secondary styles won’t apply.
Suggested patch
::: {.flow-cta-row}
-[View program](`#conference-program`)
-[Partners](`#partners-and-supporters`)
+<a class="flow-cta" href="#conference-program">View program</a>
+<a class="flow-cta-secondary" href="#partners-and-supporters">Partners</a>
:::📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| ::: {.flow-cta-row} | |
| [View program](#conference-program) | |
| [Partners](#partners-and-supporters) | |
| ::: | |
| ::: {.flow-cta-row} | |
| <a class="flow-cta" href="#conference-program">View program</a> | |
| <a class="flow-cta-secondary" href="#partners-and-supporters">Partners</a> | |
| ::: |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@content/projects/flow/20260511-flow-conference/index.qmd` around lines 35 -
38, The CTA links inside the .flow-cta-row are rendered as plain links so the
intended styles aren't applied; update the two link elements inside the :::
{.flow-cta-row} block to include the CSS class names used by the stylesheet
(e.g., add class="flow-cta" to the primary "View program" link and
class="flow-cta-secondary" to the "Partners" link) so the .flow-cta and
.flow-cta-secondary styles take effect.
Comment on lines
85
to
+107
| | Time | Session | | ||
| | --- | --- | | ||
| | 09:00 | Welcome | | ||
| | 09:15 | Intro by the organizers: Serena Tolino, Silke Schwandt, Angela Huang, Tobias Hodel | | ||
| | 09:45 | Input by Developers: From Preprocessing to Text Recognition; from Language Modeling to Information Extraction — Dana Meyer & Jonas Widmer; Malte Meister (TU Darmstadt) | | ||
| | 11:00 | Coffee break | | ||
| | 11:00 | *Coffee break* | | ||
| | 11:30 | Text Recognition Pipelines — Michael Schonhardt (TU Darmstadt); Melvin Wilde & Christopher Kuhlman | | ||
| | 13:00 | Lunch break | | ||
| | 13:00 | *Lunch break* | | ||
| | 14:00 | Named Entities — Maud Ehrmann (EPFL); Dominic; Dana Meyer & Silke Schwandt | | ||
| | 16:00 | Break | | ||
| | 16:00 | *Break* | | ||
| | 17:00 | Barbara McGillivray (King's College London) | | ||
| ::: | ||
|
|
||
| ::: {.program-day} | ||
| ### Friday, 12 June 2026 | ||
|
|
||
| | Time | Session | | ||
| | --- | --- | | ||
| | 09:15 | Corpus & Text Re-Use — TBD; Sefer Korkmaz & Inga Lange | | ||
| | 11:00 | Coffee break | | ||
| | 11:00 | *Coffee break* | | ||
| | 11:30 | LLM & Final Discussion — Sarah Oberbirchler | | ||
| | 14:00 | End of conference | | ||
| | 14:00 | *End of conference* | | ||
| ::: |
Contributor
There was a problem hiding this comment.
Program table styling hook is not attached in markup.
The tables in Lines 85-107 don’t carry the .program-table class, so the new schedule table styles in styles.css won’t apply.
Suggested patch (class attachment)
| Time | Session |
| --- | --- |
| 09:00 | Welcome |
| 09:15 | Intro by the organizers: Serena Tolino, Silke Schwandt, Angela Huang, Tobias Hodel |
| 09:45 | Input by Developers: From Preprocessing to Text Recognition; from Language Modeling to Information Extraction — Dana Meyer & Jonas Widmer; Malte Meister (TU Darmstadt) |
| 11:00 | *Coffee break* |
| 11:30 | Text Recognition Pipelines — Michael Schonhardt (TU Darmstadt); Melvin Wilde & Christopher Kuhlman |
| 13:00 | *Lunch break* |
| 14:00 | Named Entities — Maud Ehrmann (EPFL); Dominic; Dana Meyer & Silke Schwandt |
| 16:00 | *Break* |
| 17:00 | Barbara McGillivray (King's College London) |
+{.program-table}Apply the same class attachment to the Friday table.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@content/projects/flow/20260511-flow-conference/index.qmd` around lines 85 -
107, The two schedule Markdown tables inside the "::: {.program-day}" blocks
(the morning/Thursday table and the Friday table) are missing the .program-table
class so the styles in styles.css won't apply; add the .program-table class to
each table by attaching the attribute to the table markup (e.g., ensure the
Thursday table and the Friday table both carry {.program-table}) so the new
schedule table styles are applied consistently.
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/quarto-publish.yml (1)
21-22: Remove stale commented workflow config.The commented
envblock is no longer needed and adds noise to the workflow file.Suggested cleanup
- # env: - # NPM_CONFIG_USERCONFIG: ${{ runner.temp }}/.npmrc🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/quarto-publish.yml around lines 21 - 22, Remove the stale commented workflow config by deleting the commented env block that references NPM_CONFIG_USERCONFIG and runner.temp/.npmrc (the two commented lines starting with "# env:" and "# NPM_CONFIG_USERCONFIG: ${{ runner.temp }}/.npmrc") so the Quarto publish workflow no longer contains dead/commented configuration noise.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/quarto-publish.yml:
- Around line 21-22: Remove the stale commented workflow config by deleting the
commented env block that references NPM_CONFIG_USERCONFIG and runner.temp/.npmrc
(the two commented lines starting with "# env:" and "#
NPM_CONFIG_USERCONFIG: ${{ runner.temp }}/.npmrc") so the Quarto publish
workflow no longer contains dead/commented configuration noise.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.github/workflows/quarto-publish.ymlCODE_OF_CONDUCT.mdLICENSE-AGPL.mdLICENSE-CCBY.mdREADME.mdstyles.css
💤 Files with no reviewable changes (1)
- README.md
✅ Files skipped from review due to trivial changes (1)
- styles.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Proposed changes
Types of changes
Checklist
Summary by CodeRabbit
Style
Content
Documentation
Chores