fix: harden EIP-7702 backend validation in sell confirmation flow#3673
Merged
davidleomay merged 4 commits intodevelopfrom May 5, 2026
Merged
fix: harden EIP-7702 backend validation in sell confirmation flow#3673davidleomay merged 4 commits intodevelopfrom
davidleomay merged 4 commits intodevelopfrom
Conversation
) - Add cryptographic signature verification for EIP-712 delegation and EIP-7702 authorization - Validate authorization chainId against expected blockchain - Wait for transaction receipt before marking request complete - Add nonce lock to prevent concurrent relayer nonce collisions - Use pending blockTag for nonce queries
…TTP errors - Extract EIP-712 domain/types to shared constants (DRY, prevents drift) - Validate authorization.address against DELEGATOR_ADDRESS - Wrap delegation service errors as BadRequestException in confirmSell()
davidleomay
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3672
Security hardening of the EIP-7702 delegation flow for RealUnit sells:
recoverTypedDataAddress) and EIP-7702 authorization signature (recoverAuthorizationAddress) before broadcasting — prevents gas drain via garbage signatureschainIdis validated against expected blockchain before any processingwaitForTransactionReceipt(60s timeout) after broadcast — request is only marked complete if the transaction succeeds on-chainwithNonceLock) around nonce fetch + sign + broadcast prevents concurrent nonce collisions; usesblockTag: 'pending'for pending-aware nonce queries_executeBrokerBotSellInternaland_transferTokenWithUserDelegationInternalare hardenedTest plan