Skip to content

Conversation

@TaprootFreak
Copy link
Collaborator

Summary

  • EUR fiat outputs are now included in the automatic completion flow via searchOutgoingBankTx()
  • Uses valutaDate as fallback reference timestamp when isReadyDate is not set (which is intentional for EUR)
  • Matches EUR fiat outputs to bank transactions via remittanceInfo just like non-EUR

Background

EUR fiat outputs were excluded from automatic completion because isReadyDate is intentionally not set for EUR in setReadyDate(). This meant manually executed EUR bank transfers were never automatically marked as complete.

Changes

  • Extended query in searchOutgoingBankTx() to include EUR fiat outputs without isReadyDate but with valutaDate
  • Added fallback to use valutaDate when isReadyDate is null for the timestamp comparison

Test plan

  • Verify non-EUR fiat outputs still work as before (with isReadyDate)
  • Verify EUR fiat outputs are now picked up by searchOutgoingBankTx()
  • Verify matching via remittanceInfo works for manual Yapeal transfers
  • Verify valutaDate comparison prevents false matches with old bank transactions

@TaprootFreak TaprootFreak force-pushed the feature/eur-fiat-output-auto-completion branch from 9de053d to 0ffdc06 Compare January 20, 2026 20:43
@TaprootFreak TaprootFreak force-pushed the feature/eur-fiat-output-auto-completion branch from 0ffdc06 to 4194f42 Compare January 20, 2026 20:46
@TaprootFreak TaprootFreak marked this pull request as ready for review January 20, 2026 21:13
@TaprootFreak TaprootFreak merged commit ccb302c into develop Jan 20, 2026
7 checks passed
@TaprootFreak TaprootFreak deleted the feature/eur-fiat-output-auto-completion branch January 20, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants