feat(fiat-output): enable auto-completion for EUR transactions #3010
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
searchOutgoingBankTx()valutaDateas fallback reference timestamp whenisReadyDateis not set (which is intentional for EUR)remittanceInfojust like non-EURBackground
EUR fiat outputs were excluded from automatic completion because
isReadyDateis intentionally not set for EUR insetReadyDate(). This meant manually executed EUR bank transfers were never automatically marked as complete.Changes
searchOutgoingBankTx()to include EUR fiat outputs withoutisReadyDatebut withvalutaDatevalutaDatewhenisReadyDateis null for the timestamp comparisonTest plan
isReadyDate)searchOutgoingBankTx()remittanceInfoworks for manual Yapeal transfersvalutaDatecomparison prevents false matches with old bank transactions