Skip to content

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Jan 9, 2026

Automatic Release PR

This PR was automatically created after changes were pushed to develop.

Commits: 1 new commit(s)

Checklist

  • Review all changes
  • Verify CI passes
  • Approve and merge when ready for production

TaprootFreak and others added 2 commits January 9, 2026 11:43
* Disable credit card payment option

- Block credit card payments in PaymentInfoService with clear error message
- Add PAYMENT_METHOD_NOT_ALLOWED to QuoteError enum
- Return error early in TransactionHelper for card payment quotes
- Remove obsolete card-specific validation checks

* fix: removed duplicated check

---------

Co-authored-by: David May <david.leo.may@gmail.com>
@github-actions
Copy link
Author

github-actions bot commented Jan 9, 2026

🤖 PR Review Bot

⚠️ Unverified Commits (1)

The following commits are not signed/verified:

  • 54f45cc [NOTASK] improve empty string lists (Yannick1712)
How to sign commits
# SSH signing (recommended)
git config --global gpg.format ssh
git config --global user.signingkey ~/.ssh/id_ed25519.pub
git config --global commit.gpgsign true

# Re-sign last commit
git commit --amend -S --no-edit
git push --force-with-lease

⚠️ Non-Conventional Commits (3)

The following commits don't follow conventional commit format:

Expected: type(scope): description
Types: feat, fix, refactor, test, ci, docs, chore, perf, style, build, revert


⚠️ Security: 0 critical, 67 high vulnerabilities


This is an automated review. Please address the issues above.

TaprootFreak and others added 4 commits January 9, 2026 14:03
PR #2747 accidentally removed the MAERKI_BAUMANN case from blockchainToBankName(),
causing isBankMatching() to always return false for Maerki Baumann assets.

This broke the FinancialDataLog balance calculation - pending transactions
(bankTxPending, bankTxRepeat, bankTxReturn, buyCrypto) for Maerki Baumann
assets were no longer counted in minusBalance, inflating the reported
total balance by ~208k CHF.

The mapping is still needed as long as there are pending Maerki Baumann
transactions in the system.
* fix: cleanup CodeQL workflow configuration

- Remove scheduled cron job
- Add config-file reference to use existing codeql-config.yml
- Remove boilerplate comments and unused manual build step
- Simplify runs-on to ubuntu-latest

* fix: remove Python from CodeQL matrix (no analyzable Python code)

---------

Co-authored-by: Bernd <bernd@MacBook-DFX-Bernd-2026.local>
* feat: add Kraken trading fee schedule sync

- Add ExchangeTradingFeeDto for storing fee data
- Add getTradingFee() method to KrakenService using CCXT fetchTradingFee
- Add daily cronjob (6:00 AM) to sync Kraken trading fees
- Store fees in settings under 'krakenTradingFee' key
- Log when maker/taker fee rates change
- Add getKrakenTradingFee() getter to SettingService

* fix: add process ID and optimize DB writes for trading fee sync

- Add Process.EXCHANGE_TRADING_FEE_SYNC to enable job monitoring/disabling
- Only save to DB when fee actually changed (avoid daily unnecessary writes)

* refactor: change Kraken trading fee sync to on-demand before trades

- Remove cronjob-based sync (was EVERY_DAY_AT_6AM)
- Add on-demand fee check in KrakenService.buy() and sell()
- Check if fee data is older than 60 minutes before each trade
- If stale: fetch from Kraken API and update settings
- Support multiple symbols: BTC/CHF and USDT/CHF
- Separate setting keys: krakenTradingFee:BTC/CHF, krakenTradingFee:USDT/CHF
- Each entry stores timestamp in 'updated' field

This ensures fee data is always fresh when executing trades,
rather than potentially being up to 24 hours old with cronjob approach.

* fix: add error handling for trading fee API calls

API errors no longer block trades. If fee refresh fails,
use cached/stale value and log warning instead.

* refactor: improve symbol matching and use parallel execution

- Use exact symbol matching (tradePair/reversePair) instead of includes()
- Use Promise.all() for parallel fee refresh instead of sequential loop

* fix: check ALL tracked trading fees before every Kraken trade

Before ANY trade on Kraken (regardless of which pair), ensure both
BTC/CHF and USDT/CHF fees are up-to-date (not older than 60 minutes).

- Rename ensureTradingFeeUpToDate() to ensureAllTradingFeesUpToDate()
- Remove from/to parameters - always check all TRACKED_SYMBOLS
- Keep parallel execution with Promise.all()

* fix: handle invalid date in isStale() defensively

Treat corrupted/invalid updated timestamps as stale to ensure
fee refresh rather than silently using potentially outdated data.

* feat: refactoring

---------

Co-authored-by: David May <david.leo.may@gmail.com>
@TaprootFreak TaprootFreak merged commit ab58126 into master Jan 9, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants