-
Notifications
You must be signed in to change notification settings - Fork 18
Release: develop -> master #2892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Disable credit card payment option - Block credit card payments in PaymentInfoService with clear error message - Add PAYMENT_METHOD_NOT_ALLOWED to QuoteError enum - Return error early in TransactionHelper for card payment quotes - Remove obsolete card-specific validation checks * fix: removed duplicated check --------- Co-authored-by: David May <david.leo.may@gmail.com>
Author
🤖 PR Review Bot
|
PR #2747 accidentally removed the MAERKI_BAUMANN case from blockchainToBankName(), causing isBankMatching() to always return false for Maerki Baumann assets. This broke the FinancialDataLog balance calculation - pending transactions (bankTxPending, bankTxRepeat, bankTxReturn, buyCrypto) for Maerki Baumann assets were no longer counted in minusBalance, inflating the reported total balance by ~208k CHF. The mapping is still needed as long as there are pending Maerki Baumann transactions in the system.
* fix: cleanup CodeQL workflow configuration - Remove scheduled cron job - Add config-file reference to use existing codeql-config.yml - Remove boilerplate comments and unused manual build step - Simplify runs-on to ubuntu-latest * fix: remove Python from CodeQL matrix (no analyzable Python code) --------- Co-authored-by: Bernd <bernd@MacBook-DFX-Bernd-2026.local>
* feat: add Kraken trading fee schedule sync - Add ExchangeTradingFeeDto for storing fee data - Add getTradingFee() method to KrakenService using CCXT fetchTradingFee - Add daily cronjob (6:00 AM) to sync Kraken trading fees - Store fees in settings under 'krakenTradingFee' key - Log when maker/taker fee rates change - Add getKrakenTradingFee() getter to SettingService * fix: add process ID and optimize DB writes for trading fee sync - Add Process.EXCHANGE_TRADING_FEE_SYNC to enable job monitoring/disabling - Only save to DB when fee actually changed (avoid daily unnecessary writes) * refactor: change Kraken trading fee sync to on-demand before trades - Remove cronjob-based sync (was EVERY_DAY_AT_6AM) - Add on-demand fee check in KrakenService.buy() and sell() - Check if fee data is older than 60 minutes before each trade - If stale: fetch from Kraken API and update settings - Support multiple symbols: BTC/CHF and USDT/CHF - Separate setting keys: krakenTradingFee:BTC/CHF, krakenTradingFee:USDT/CHF - Each entry stores timestamp in 'updated' field This ensures fee data is always fresh when executing trades, rather than potentially being up to 24 hours old with cronjob approach. * fix: add error handling for trading fee API calls API errors no longer block trades. If fee refresh fails, use cached/stale value and log warning instead. * refactor: improve symbol matching and use parallel execution - Use exact symbol matching (tradePair/reversePair) instead of includes() - Use Promise.all() for parallel fee refresh instead of sequential loop * fix: check ALL tracked trading fees before every Kraken trade Before ANY trade on Kraken (regardless of which pair), ensure both BTC/CHF and USDT/CHF fees are up-to-date (not older than 60 minutes). - Rename ensureTradingFeeUpToDate() to ensureAllTradingFeesUpToDate() - Remove from/to parameters - always check all TRACKED_SYMBOLS - Keep parallel execution with Promise.all() * fix: handle invalid date in isStale() defensively Treat corrupted/invalid updated timestamps as stale to ensure fee refresh rather than silently using potentially outdated data. * feat: refactoring --------- Co-authored-by: David May <david.leo.may@gmail.com>
TaprootFreak
approved these changes
Jan 9, 2026
davidleomay
approved these changes
Jan 9, 2026
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist