Release: develop -> master #2889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: use correct refund currency (CHF only for CH/LI IBANs) * fix: fix test failures for isDomesticIban and refundPrice - Use Object.assign in TestUtil.provideConfig to preserve class methods (spread operator only copies enumerable properties, not methods) - Add pricingService.getPrice mock to manualPrice test (required since new code calls getPrice for refundPrice conversion) - Update expected refundAmount from 99.87 to 99.88 (rounding adjustment) * fix: valid only price --------- Co-authored-by: TaprootFreak <142087526+TaprootFreak@users.noreply.github.com>
Author
🤖 PR Review Bot
|
TaprootFreak
approved these changes
Jan 9, 2026
…2884) Remove the confirmation requirement from checkTransferCompletion(). Previously, Bitcoin withdrawals from exchanges (e.g., Binance) had to wait for 1 blockchain confirmation before the liquidity pipeline could continue and trigger buy payouts. Now, as soon as the withdrawal TX is visible in the mempool, the pipeline completes and buy payouts can be created immediately. This works because: - getBalance() already includes untrusted_pending (unconfirmed external) - sendMany() already uses include_unsafe: true for coin selection - CPFP fee multiplier is active for unconfirmed UTXOs Expected improvement: Buy payouts can occur in the same block as the exchange withdrawal instead of the next block (~10-15 min faster).
* feat: enhance resetAmlCheck with full reset and audit logging - Add priceSteps, priceDefinitionAllowedDate, usedFees, bankFeeAmount to resetAmlCheck() in BuyFiat entity for complete price recalculation - Create SupportLog entry when resetAmlCheck is called, documenting: - Previous amlCheck and amlReason - Output amount and asset - FiatOutput ID and transmission status - Price definition date - Export SupportLogService from SupportIssueModule - Import SupportIssueModule in SellCryptoModule This ensures full traceability when admin resets a BuyFiat transaction, e.g. when bank (Yapeal) rejects a payout. * fix: add null check for userData in resetAmlCheck * fix: add outputAsset to relations for complete audit log * test: add SupportLogService mock to buy-fiat.service.spec
- Remove maerkiBaumannEnable flag from Country entity - Remove Maerki-specific country check logic from Bank entity - Update default bank for SEPA payments from Maerki to Yapeal - Remove Maerki from blockchain-to-bank mapping - Update all tests to use Yapeal instead of Maerki - Replace maerkiEUR/maerkiCHF mocks with yapealEUR/yapealCHF - Preserve IbanBankName.MAERKI and Blockchain.MAERKI_BAUMANN enums for database compatibility
davidleomay
approved these changes
Jan 9, 2026
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist