-
Notifications
You must be signed in to change notification settings - Fork 18
Release: develop -> master #2873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
🤖 PR Review Bot
|
Add Util.round(amount, 2) when setting FiatOutput.amount in: - create(): after entity creation from DTO - createInternal(): when calculating from buyFiats and before save - update(): before saving DTO amount Fiat amounts must always be rounded to 2 decimal places for correct bank transaction processing.
* fix: case-insensitive bankUsage matching in findMatchingBuy The remittanceInfo was compared case-sensitively with bankUsage, causing transactions with lowercase usage codes (e.g. 6ed3-090b-25a8) to not match their routes (stored as 6ED3-090B-25A8). Add .toUpperCase() to normalized candidate for consistent matching. * fix: correct order of toUpperCase and O-to-0 replacement Move toUpperCase() before replace(/O/g, '0') so that lowercase 'o' is first converted to 'O', then replaced with '0'. This handles edge cases like '6ed3-o90b-25a8' where user types lowercase 'o' instead of '0'.
TaprootFreak
approved these changes
Jan 7, 2026
davidleomay
approved these changes
Jan 7, 2026
* fix: improved bank refund * fix: enforce creditor data for bank refunds * fix: tests
* feat: add Special ZCHF 0.5% fee for userData 363001 Add migration that: - Creates new 'Special ZCHF 0.5%' fee (type: Special, rate: 0.005) - Applies to all ZCHF chains: Ethereum, Polygon, Arbitrum, Optimism, BSC, Base - Assigns fee to userData 363001 via individualFees field This reduces the fee for all ZCHF buy/sell/swap transactions from the standard Organization rate (1.99%-2.49%) to 0.5%. * fix: correct blockchainFactor and add financialTypes to fee migration - Change blockchainFactor from 1 to 0 (consistent with Fee 67, 111) - Add financialTypes: 'CHF' (consistent with existing ZCHF fees) - Use unique label 'Special ZCHF 0.5% UserData 363001' to avoid collisions - Fix down() migration: use STUFF/LEFT instead of fragile SUBSTRING
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist