Skip to content

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Jan 7, 2026

Automatic Release PR

This PR was automatically created after changes were pushed to develop.

Commits: 1 new commit(s)

Checklist

  • Review all changes
  • Verify CI passes
  • Approve and merge when ready for production

@github-actions
Copy link
Author

github-actions bot commented Jan 7, 2026

🤖 PR Review Bot

⚠️ Unverified Commits (1)

The following commits are not signed/verified:

  • b234dae [NOTASK] add bankDataUserMismatch auto fail (Yannick1712)
How to sign commits
# SSH signing (recommended)
git config --global gpg.format ssh
git config --global user.signingkey ~/.ssh/id_ed25519.pub
git config --global commit.gpgsign true

# Re-sign last commit
git commit --amend -S --no-edit
git push --force-with-lease

⚠️ Non-Conventional Commits (4)

The following commits don't follow conventional commit format:

  • 8035742 Refactoring
  • b2b1d56 Refactoring 2
  • b234dae [NOTASK] add bankDataUserMismatch auto fail
  • bd29095 Bank refund checks (Bank refund checks #2880)

Expected: type(scope): description
Types: feat, fix, refactor, test, ci, docs, chore, perf, style, build, revert


⚠️ Security: 0 critical, 67 high vulnerabilities


This is an automated review. Please address the issues above.

Add Util.round(amount, 2) when setting FiatOutput.amount in:
- create(): after entity creation from DTO
- createInternal(): when calculating from buyFiats and before save
- update(): before saving DTO amount

Fiat amounts must always be rounded to 2 decimal places for
correct bank transaction processing.
* fix: case-insensitive bankUsage matching in findMatchingBuy

The remittanceInfo was compared case-sensitively with bankUsage,
causing transactions with lowercase usage codes (e.g. 6ed3-090b-25a8)
to not match their routes (stored as 6ED3-090B-25A8).

Add .toUpperCase() to normalized candidate for consistent matching.

* fix: correct order of toUpperCase and O-to-0 replacement

Move toUpperCase() before replace(/O/g, '0') so that lowercase 'o'
is first converted to 'O', then replaced with '0'.

This handles edge cases like '6ed3-o90b-25a8' where user types
lowercase 'o' instead of '0'.
Yannick1712 and others added 3 commits January 8, 2026 03:52
* fix: improved bank refund

* fix: enforce creditor data for bank refunds

* fix: tests
* feat: add Special ZCHF 0.5% fee for userData 363001

Add migration that:
- Creates new 'Special ZCHF 0.5%' fee (type: Special, rate: 0.005)
- Applies to all ZCHF chains: Ethereum, Polygon, Arbitrum, Optimism, BSC, Base
- Assigns fee to userData 363001 via individualFees field

This reduces the fee for all ZCHF buy/sell/swap transactions from
the standard Organization rate (1.99%-2.49%) to 0.5%.

* fix: correct blockchainFactor and add financialTypes to fee migration

- Change blockchainFactor from 1 to 0 (consistent with Fee 67, 111)
- Add financialTypes: 'CHF' (consistent with existing ZCHF fees)
- Use unique label 'Special ZCHF 0.5% UserData 363001' to avoid collisions
- Fix down() migration: use STUFF/LEFT instead of fragile SUBSTRING
@TaprootFreak TaprootFreak merged commit abfb18b into master Jan 8, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants