Skip to content

use constexpr in Core where possible #5664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ab9rf merged 3 commits into from
Nov 24, 2025
+4 −4
Merged

use constexpr in Core where possible #5664

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12a311e
use `constexpr` in `Core` where possible
ab9rf Nov 24, 2025
61d8540
fix row format, roll back one `constexpr`
ab9rf Nov 24, 2025
8f5aa08
Merge branch 'develop' into constexpr-in-core
ab9rf Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions library/Core.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ uint32_t PerfCounters::getUnpausedFps() {

struct CommandDepthCounter
{
static const int MAX_DEPTH = 20;
static constexpr int MAX_DEPTH = 20;
static thread_local int depth;
CommandDepthCounter() { depth++; }
~CommandDepthCounter() { depth--; }
Expand Down Expand Up @@ -902,8 +902,8 @@ command_result Core::runCommand(color_ostream &con, const std::string &first_, s
}
else if (first == "plug")
{
const char *header_format = "%30s %10s %4s %8s\n";
const char *row_format = "%30s %10s %4i %8s\n";
constexpr auto header_format = "%30s %10s %4s %8s\n";
constexpr auto row_format = "%30s %10s %4zu %8s\n";
con.print(header_format, "Name", "State", "Cmds", "Enabled");

plug_mgr->refresh();
Expand Down Expand Up @@ -1601,7 +1601,7 @@ bool Core::InitMainThread() {
{
if (!Version::git_xml_match())
{
const char *msg = (
constexpr auto msg = (
"*******************************************************\n"
"* BIG, UGLY ERROR MESSAGE *\n"
"*******************************************************\n"
Expand Down