Skip to content

add regression test for size of global_table #5052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myk002 merged 2 commits into from
Nov 29, 2024
Merged

add regression test for size of global_table #5052

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a645fbc
add regression test for size of global_table
myk002 Nov 28, 2024
5dfaa56
simplify test
myk002 Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions test/core.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,15 @@ function test.getHackPath_chdir()
expect.eq(clean_path(dfhack.getHackPath()), clean_path(fs.getcwd()))
end)
end

-- validates that the size in df.globals.xml is correct
function test.global_table_size()
local elem_size = df.global_table_entry:sizeof()
local actual_arr_size = 0
while df._displace(df.global.global_table[0], actual_arr_size, elem_size).address do
actual_arr_size = actual_arr_size + 1
end
local declared_arr_size = df.global.global_table:sizeof() // elem_size
expect.eq(declared_arr_size, actual_arr_size,
('global_table size mismatch: expected: %d, actual: %d'):format(declared_arr_size, actual_arr_size))
end
Loading