Open
Conversation
RMcVelia
reviewed
Mar 24, 2026
| operator = custom_rule.value.operator | ||
| match_values = custom_rule.value.patterns | ||
| negation_condition = custom_rule.value.negate | ||
| transforms = custom_rule.value.transforms |
Contributor
There was a problem hiding this comment.
Lets hardcode the list of exclusions in the module.
The calling service would just declare block_paths = true (or that would be the default).
negation_condition and transforms can be removed.
shaheislamdfe
force-pushed
the
2613-spike-fd-block-by-path
branch
from
38ed4ce to
9d412db
Compare
RMcVelia
reviewed
Apr 8, 2026
| variable "block_common_paths" { | ||
| type = bool | ||
| nullable = false | ||
| default = true |
Contributor
There was a problem hiding this comment.
lets make this false to start with. That we we would selectively apply to start with and change to true once we are happy with it
shaheislamdfe
force-pushed
the
2613-spike-fd-block-by-path
branch
from
9d412db to
743afd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Changes proposed in this pull request
Guidance to review
Before merging
After merging
Checklist
Devopslabel