Add Airbyte stream configuration job for .NET apps#175
Draft
Add Airbyte stream configuration job for .NET apps#175
Conversation
37c2895 to
b091d6c
Compare
b091d6c to
e5945c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The current
airbyte-stream-updatejob runs a rake task, which won't work for .NET apps. This adds the equivalent job that works with the applications using the .NET analytics library.Changes proposed in this pull request
Add
is_rails_applicationandis_dotnet_applicationand only deploy corresponding jobs if the respective variables are set.Adds a
dotnet_application_directoryvariable that can be set if the container doesn't have a working directory set (or if the container's working directory doesn't contain the deployment script). (I didn't use theworking_diroption as that seems to be ignored if the docker image has a working directory set.)Guidance to review
The .NET side has been successfully tested in the
trs-airbytebranch, but a Ruby app should be tested with this change too.Before merging
Merge #173 and #174 and incorporate those changes into this PR.
After merging
Update any applications referencing this module to set the new variables, where appropriate.
Checklist
Devopslabel