Skip to content

Add negative game tests for all advancements #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubensworks merged 2 commits into from
Feb 28, 2026
Merged

Add negative game tests for all advancements #195

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9c6a6f
Initial plan
Copilot Feb 28, 2026
75173d4
Add negative game tests for all advancements
Copilot Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 113 additions & 0 deletions loader-common/src/main/java/org/cyclops/colossalchests/gametest/GameTestsCommon.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,6 +1146,15 @@ protected boolean isFabric() {
}
}

@GameTest(template = TEMPLATE_EMPTY)
public void testAdvancementRootNegative(GameTestHelper helper) {
ServerPlayer serverPlayer = makeMockServerPlayer(helper);
serverPlayer.getInventory().add(new ItemStack(Items.DIRT));
CriteriaTriggers.INVENTORY_CHANGED.trigger(serverPlayer, serverPlayer.getInventory(), new ItemStack(Items.DIRT));

helper.succeedWhen(() -> assertAdvancementNotDone(helper, serverPlayer, ResourceLocation.parse("colossalchests:root")));
}

@GameTest(template = TEMPLATE_EMPTY)
public void testAdvancementRoot(GameTestHelper helper) {
ServerPlayer serverPlayer = makeMockServerPlayer(helper);
Expand All @@ -1155,6 +1164,14 @@ public void testAdvancementRoot(GameTestHelper helper) {
helper.succeedWhen(() -> assertAdvancementDone(helper, serverPlayer, ResourceLocation.parse("colossalchests:root")));
}

@GameTest(template = TEMPLATE_EMPTY)
public void testAdvancementUncolossalNegative(GameTestHelper helper) {
ServerPlayer serverPlayer = makeMockServerPlayer(helper);
placeBlockAsServerPlayer(helper, serverPlayer, POS, Blocks.CHEST);

helper.succeedWhen(() -> assertAdvancementNotDone(helper, serverPlayer, ResourceLocation.parse("colossalchests:uncolossal")));
}

@GameTest(template = TEMPLATE_EMPTY)
public void testAdvancementUncolossal(GameTestHelper helper) {
ServerPlayer serverPlayer = makeMockServerPlayer(helper);
Expand All @@ -1163,6 +1180,41 @@ public void testAdvancementUncolossal(GameTestHelper helper) {
helper.succeedWhen(() -> assertAdvancementDone(helper, serverPlayer, ResourceLocation.parse("colossalchests:uncolossal")));
}

@GameTest(template = TEMPLATE_EMPTY)
public void testAdvancementBaseWoodNegative(GameTestHelper helper) {
testAdvancementBaseNegative(helper, ChestMaterial.COPPER, "colossalchests:base/wood");
}

@GameTest(template = TEMPLATE_EMPTY)
public void testAdvancementBaseCopperNegative(GameTestHelper helper) {
testAdvancementBaseNegative(helper, ChestMaterial.WOOD, "colossalchests:base/copper");
}

@GameTest(template = TEMPLATE_EMPTY)
public void testAdvancementBaseIronNegative(GameTestHelper helper) {
testAdvancementBaseNegative(helper, ChestMaterial.WOOD, "colossalchests:base/iron");
}

@GameTest(template = TEMPLATE_EMPTY)
public void testAdvancementBaseSilverNegative(GameTestHelper helper) {
testAdvancementBaseNegative(helper, ChestMaterial.WOOD, "colossalchests:base/silver");
}

@GameTest(template = TEMPLATE_EMPTY)
public void testAdvancementBaseGoldNegative(GameTestHelper helper) {
testAdvancementBaseNegative(helper, ChestMaterial.WOOD, "colossalchests:base/gold");
}

@GameTest(template = TEMPLATE_EMPTY)
public void testAdvancementBaseDiamondNegative(GameTestHelper helper) {
testAdvancementBaseNegative(helper, ChestMaterial.WOOD, "colossalchests:base/diamond");
}

@GameTest(template = TEMPLATE_EMPTY)
public void testAdvancementBaseObsidianNegative(GameTestHelper helper) {
testAdvancementBaseNegative(helper, ChestMaterial.WOOD, "colossalchests:base/obsidian");
}

@GameTest(template = TEMPLATE_EMPTY)
public void testAdvancementBaseWood(GameTestHelper helper) {
testAdvancementBase(helper, ChestMaterial.WOOD, "colossalchests:base/wood");
Expand Down Expand Up @@ -1198,6 +1250,41 @@ public void testAdvancementBaseObsidian(GameTestHelper helper) {
testAdvancementBase(helper, ChestMaterial.OBSIDIAN, "colossalchests:base/obsidian");
}

@GameTest(template = TEMPLATE_EMPTY)
public void testAdvancementSizeWoodNegative(GameTestHelper helper) {
testAdvancementSizeNegative(helper, ChestMaterial.WOOD, "colossalchests:size/wood");
}

@GameTest(template = TEMPLATE_EMPTY)
public void testAdvancementSizeCopperNegative(GameTestHelper helper) {
testAdvancementSizeNegative(helper, ChestMaterial.COPPER, "colossalchests:size/copper");
}

@GameTest(template = TEMPLATE_EMPTY)
public void testAdvancementSizeIronNegative(GameTestHelper helper) {
testAdvancementSizeNegative(helper, ChestMaterial.IRON, "colossalchests:size/iron");
}

@GameTest(template = TEMPLATE_EMPTY)
public void testAdvancementSizeSilverNegative(GameTestHelper helper) {
testAdvancementSizeNegative(helper, ChestMaterial.SILVER, "colossalchests:size/silver");
}

@GameTest(template = TEMPLATE_EMPTY)
public void testAdvancementSizeGoldNegative(GameTestHelper helper) {
testAdvancementSizeNegative(helper, ChestMaterial.GOLD, "colossalchests:size/gold");
}

@GameTest(template = TEMPLATE_EMPTY)
public void testAdvancementSizeDiamondNegative(GameTestHelper helper) {
testAdvancementSizeNegative(helper, ChestMaterial.DIAMOND, "colossalchests:size/diamond");
}

@GameTest(template = TEMPLATE_EMPTY)
public void testAdvancementSizeObsidianNegative(GameTestHelper helper) {
testAdvancementSizeNegative(helper, ChestMaterial.OBSIDIAN, "colossalchests:size/obsidian");
}

@GameTest(template = TEMPLATE_EMPTY)
public void testAdvancementSizeWood(GameTestHelper helper) {
testAdvancementSize(helper, ChestMaterial.WOOD, "colossalchests:size/wood");
Expand Down Expand Up @@ -1233,6 +1320,24 @@ public void testAdvancementSizeObsidian(GameTestHelper helper) {
testAdvancementSize(helper, ChestMaterial.OBSIDIAN, "colossalchests:size/obsidian");
}

private void testAdvancementBaseNegative(GameTestHelper helper, ChestMaterial material, String advancementId) {
BlockPos excludedWall = POS.offset(1, 0, 0);
createChest(helper, POS, material, 2, Sets.newHashSet(excludedWall));
ServerPlayer serverPlayer = makeMockServerPlayer(helper);
placeBlockAsServerPlayer(helper, serverPlayer, excludedWall, material.getBlockWall());

helper.succeedWhen(() -> assertAdvancementNotDone(helper, serverPlayer, ResourceLocation.parse(advancementId)));
}

private void testAdvancementSizeNegative(GameTestHelper helper, ChestMaterial material, String advancementId) {
BlockPos excludedWall = POS.offset(1, 0, 0);
createChest(helper, POS, material, 2, Sets.newHashSet(excludedWall));
ServerPlayer serverPlayer = makeMockServerPlayer(helper);
placeBlockAsServerPlayer(helper, serverPlayer, excludedWall, material.getBlockWall());

helper.succeedWhen(() -> assertAdvancementNotDone(helper, serverPlayer, ResourceLocation.parse(advancementId)));
}

private void testAdvancementBase(GameTestHelper helper, ChestMaterial material, String advancementId) {
BlockPos excludedWall = POS.offset(1, 0, 0);
createChest(helper, POS, material, 2, Sets.newHashSet(excludedWall));
Expand Down Expand Up @@ -1264,6 +1369,14 @@ private void placeBlockAsServerPlayer(GameTestHelper helper, ServerPlayer server
new BlockHitResult(Vec3.atCenterOf(helper.absolutePos(pos)), Direction.DOWN, helper.absolutePos(pos), false)));
}

private void assertAdvancementNotDone(GameTestHelper helper, ServerPlayer player, ResourceLocation advancementId) {
AdvancementHolder holder = helper.getLevel().getServer().getAdvancements().get(advancementId);
helper.assertTrue(holder != null, "Advancement " + advancementId + " not found");
helper.assertTrue(
!player.getAdvancements().getOrStartProgress(holder).isDone(),
"Advancement " + advancementId + " should not have been obtained");
}

private void assertAdvancementDone(GameTestHelper helper, ServerPlayer player, ResourceLocation advancementId) {
AdvancementHolder holder = helper.getLevel().getServer().getAdvancements().get(advancementId);
helper.assertTrue(holder != null, "Advancement " + advancementId + " not found");
Expand Down