Skip to content

Update D3D OOVPAs #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ergo720 merged 8 commits into from
Aug 23, 2025
Merged

Update D3D OOVPAs #231

ergo720 merged 8 commits into from
Aug 23, 2025

Conversation

@RadWolfie
Copy link
Member

@RadWolfie RadWolfie commented Aug 23, 2025

Updated:

  • D3D_BlockOnResource variant signatures
  • D3DDevice_SetTextureState_ColorKeyColor variant signatures

Renamed:

  • D3DDevice_SetTextureState_ColorKeyColor_0__LTCG_esi1_ebx2 to D3DDevice_SetTextureState_ColorKeyColor_0__LTCG_eax1_ebx2

Added:

Thanks to Luke for bringing D3D_BlockOnResource and D3DDevice_SetTextureState_ColorKeyColor LTCG variants has incorrect parameters to my attention.

After series of testing with unit test tool, they are passing.

@RadWolfie
d3d8: add D3DDevice_SetTextureState_Deferred signature
d8b1827 
Added:
- 3911
@RadWolfie
d3d8: mark end range for D3DDevice_SetRenderState_Deferred detection
7176367
@RadWolfie
d3d8ltcg: update D3D_BlockOnResource signatures
ba3754f 
Updated:
- D3D_BlockOnResource_0__LTCG_eax1 (2024 to 3911)
- D3D_BlockOnResource_0__LTCG_ecx1 (2036 to 4039)
- D3D_BlockOnResource_0__LTCG_eax1 (2048 to 4039)
- D3D_BlockOnResource_0__LTCG_eax1 (2060 to 5455)
@RadWolfie
d3d8: update D3D_BlockOnResource signatures
f3f7700 
Updated:
- 3911
- 3034
@github-actions github-actions bot added OOVPA Any OOVPA change relative needs-verification Require verification before approval D3D8 OOVPA relative topic D3D8LTCG OOVPA relative topic labels Aug 23, 2025
ergo720
ergo720 reviewed Aug 23, 2025
View reviewed changes
ergo720
ergo720 reviewed Aug 23, 2025
View reviewed changes
@RadWolfie
d3d8ltcg: fix D3DDevice_SetTextureState_ColorKeyColor variant signatures
0487a70 
changed esi1 to eax1 register

Updated:
- 2024 to 3911
- 2036 to 5233
- 2048 to 5788
@RadWolfie
d3d8ltcg: update D3DDevice_SetTextureState_ColorKeyColor_4__LTCG_eax1…
c12659d 
… signatures

Updated:
- 2048 to 4039
- 2060 to 4531
@RadWolfie
d3d8ltcg: update D3DDevice_SetTextureState_ColorKeyColor signatures
caf8924 
Updated:
- 1036 to 4432
- 1024 to 5788
@RadWolfie
d3d8: update D3DDevice_SetTextureState_ColorKeyColor signatures
e003472 
Updated:
- 3911
- 4034
@ergo720 ergo720 merged commit 20eced5 into Cxbx-Reloaded:master Aug 23, 2025
13 of 14 checks passed
@ergo720 ergo720 removed the needs-verification Require verification before approval label Aug 23, 2025
@RadWolfie RadWolfie deleted the d3d-oovpa-updates branch August 23, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ergo720 ergo720 ergo720 approved these changes

Assignees

No one assigned

Labels

D3D8LTCG OOVPA relative topic D3D8 OOVPA relative topic OOVPA Any OOVPA change relative

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add D3DDevice_SetTextureState_Deferred symbol

2 participants

@RadWolfie @ergo720