Skip to content

Fix biomes for igloos and mansions #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xpple wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix biomes for igloos and mansions #140

xpple wants to merge 3 commits into from

Conversation

@xpple
Copy link

@xpple xpple commented Apr 10, 2025 •
edited
Loading

When looking through BiomeTagsProvider#addTags I noticed that the biomes for Igloos were missing Snowy Plains, and that the newly added biome Pale Garden was missing for the Mansion structure. Note that the ID snowy_tundra was changed to snowy_plains in 21w40a.

@xpple
Copy link
Author

xpple commented May 6, 2025

I now realise that in-code snowy_plains == snowy_tundra. If you want, I can revert the Igloo change. The Mansion change remains valid, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@xpple