Windrose: Update UserLeaveRegex for account disconnection#1901
Draft
KairuByte wants to merge 1 commit intoCubeCoders:mainfrom
Draft
Windrose: Update UserLeaveRegex for account disconnection#1901KairuByte wants to merge 1 commit intoCubeCoders:mainfrom
KairuByte wants to merge 1 commit intoCubeCoders:mainfrom
Conversation
More encompassing account disconnection regex which includes ungraceful disconnects (such as client crashes)
KairuByte
changed the title
KairuByte
changed the title
Contributor
Author
|
Cant for the life of me get this to hit on improper disconnects even though the message is identical for both proper and improper. I suspect I may be running into an issue where the edited GenericModule.kvp file isnt being properly honored, but was unable to determine if that was the case in the time I had available. Will look into this further in the near future. |
Collaborator
|
AMP doesn't behave well when the join matches on name and id but the leave only on id |
Contributor
Author
|
That's a hard oof. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More encompassing account disconnection regex which includes ungraceful disconnects (such as client crashes or
taskkill -f -im Windrose-Win64-Shipping.exe)