Skip to content

Nodset and sideset support in initial conditions#303

Merged
cmhamel merged 1 commit into
mainfrom
initial_conditions/add_nset_and_sset_support
May 30, 2026
Merged

Nodset and sideset support in initial conditions#303
cmhamel merged 1 commit into
mainfrom
initial_conditions/add_nset_and_sset_support

Conversation

@cmhamel
Copy link
Copy Markdown
Contributor

@cmhamel cmhamel commented May 30, 2026

Adding nodeset and sideset support. A few tweaks to tests and app tools as well. Bumping to version 0.14 since the ics interface is a breaking change.

…ls as well. Bumping to version 0.14 since the ics interface is a breaking change.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2026

Codecov Report

❌ Patch coverage is 62.22222% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.33%. Comparing base (d52c12c) to head (74f9445).

Files with missing lines Patch % Lines
src/AppTools.jl 28.57% 15 Missing ⚠️
src/InitialConditions.jl 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
+ Coverage   61.33%   66.33%   +4.99%     
==========================================
  Files          55       55              
  Lines        4811     4848      +37     
==========================================
+ Hits         2951     3216     +265     
+ Misses       1860     1632     -228     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cmhamel
Copy link
Copy Markdown
Contributor Author

cmhamel commented May 30, 2026

@lxmota for your awareness InitialCondition now supports blocks, nodesets, and sidesets. Its still a little awkward in terms of setup for fields that are not the primary solution field such as velocity in dynamics.

The syntax is now

ic = InitialCondition("displ_x", func; block_name = "my_block")

or

ic = InitialCondition("displ_x", func; nodeset_name = "my_nset")

or

ic = InitialCondition("displ_x", func; sideset_name = "my_sset")

If you want to use this machinery for rates of the primary solution field (such as velocity) you need to specify the component of the primary field name. So for an IC on velocity_x it would still be

ic = InitialCondition("displ_x", func; block_name = "my_block")

and then call

update_field_ics!(V, [ic])

where V is a velocity field.

Maybe its worth changing the interface to support a component keyword.

@cmhamel cmhamel merged commit fd5f098 into main May 30, 2026
10 of 13 checks passed
@cmhamel cmhamel deleted the initial_conditions/add_nset_and_sset_support branch May 30, 2026 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant