Hide bot consoles unless we debug. #133
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Not sure about this. Having consoles open is pretty useful from a perspective of knowing the bot is running. I think this could possibly be done at a LadderManager config level, rather than a config for each bot. Theres also the danger we have too many features connected to the debug flag, so its an 'all-or-nothing' flag instead of having more fine tuned debug options. |
|
Maybe make a tick box like for realtime mode? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tweakimp asked for this and I think it makes sense.
Showing the console is just a visual indicator that the bot started. Not needed if we do not debug. Because it can be assumed that at least starting the bot should work.