Skip to content

Fix install button selector for Falcon UI change #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mraible merged 2 commits into from
Mar 18, 2026
Merged

Fix install button selector for Falcon UI change #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6234c23
Update pylintrc py-version from 3.9 to 3.13
mraible Mar 17, 2026
22fcbd9
Fix install button selector: 'Install app' renamed to 'Save and install'
mraible Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ persistent=yes

# Minimum Python version to use for version dependent checks. Will default to
# the version used to run pylint.
py-version=3.9
py-version=3.13

# Discover python modules and packages in the file system subtree.
recursive=no
Expand Down
11 changes: 6 additions & 5 deletions e2e/src/pages/AppCatalogPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,12 +174,13 @@ export class AppCatalogPage extends BasePage {
}

/**
* Click the final "Install app" button
* Click the final "Save and install" button
*/
private async clickInstallAppButton(): Promise<void> {
const installButton = this.page.getByRole('button', { name: 'Install app' });
const installButton = this.page.getByRole('button', { name: 'Save and install' })
.or(this.page.getByRole('button', { name: 'Install app' }));

await this.waiter.waitForVisible(installButton, { description: 'Install app button' });
await this.waiter.waitForVisible(installButton, { description: 'Save and install button' });

// Wait for button to be enabled
await installButton.waitFor({ state: 'visible', timeout: 10000 });
Expand All @@ -188,8 +189,8 @@ export class AppCatalogPage extends BasePage {
// Simple delay for form to enable button
await this.waiter.delay(1000);

await this.smartClick(installButton, 'Install app button');
this.logger.info('Clicked Install app button');
await this.smartClick(installButton, 'Save and install button');
this.logger.info('Clicked Save and install button');
}

/**
Expand Down
Loading