-
Notifications
You must be signed in to change notification settings - Fork 34
alks-cli that supports changeminder #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….npmjs.org/ && npm shrinkwrap' to update shrinkwrap so packages are pulled from npmjs and CI can get them.
…cuase USERNAME is a reserved enviornment variable in Mac OS and running e2e tests locally kept not setting USERNAME properly.
…cuase USERNAME is a reserved enviornment variable in Mac OS and running e2e tests locally kept not setting USERNAME properly.
… and all the other tests run correctly.
… We were not able to get the 'alks developer login2fa' test to run so this code is inert.
…re refresh token.
Increase timeout to 30s and add exp_continue to properly handle sequential prompts. Reduces Docker build step 13 from 150s to <10s.
…bug why 'alks developer login2fa' test was failing. Ultimately we are skipping that test because it is flaky. I added a todo to follow up and try to fix it later.
…rams/how-to-test.md. Its an empty file.
… params then use changeminder. Otherwise normal getkeys body can be used and prod requests for Admin won't result in a 400 because of changeMinder.
3c9e2b3 to
2dabfc5
Compare
…o artifactory. CI/CD will fill without them.
| @@ -0,0 +1,11 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this file supposed to be committed? since it has some local file paths?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
…in PR and shouldn't be committed to repo.
codykoelemay
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log Items
Original work was done by @samsolaimani . I am picking up the QA and will deploy beta package.
Description
Code presents new command line switches that supports
session openandsession consolecommands to participate in ChangeMinder.Rally:
US1626026: Update CLI to use new ALKS JS and new params