-
Notifications
You must be signed in to change notification settings - Fork 1
Update for React Native version 1.0.0 docs #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…emove deprecated migration guide
…eaking changes section, and adjust category positions for guides and product notes.
Summary of ChangesHello @jayant-dhingra-cb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly updates the documentation for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides a comprehensive update to the documentation for the upcoming version 1.0.0 of cbl-reactnative. The changes include a new migration guide, updated release notes, and revised code examples across several documents to reflect the new APIs for logging, replication configuration, and event listeners.
The new documentation is well-structured and the examples are much clearer. I've identified a few areas for improvement:
- There's an inconsistent use of Docusaurus admonition syntax (
::::vs:::). I've left comments to correct this to ensure proper rendering. - One of the code examples uses a magic number instead of an enum constant, which could be improved for clarity.
Overall, this is a great update that will be very helpful for developers migrating to or starting with version 1.0.0.
| } | ||
|
|
||
| // Check activity level | ||
| if (change.status.getActivityLevel() === 3) { // IDLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and to avoid magic numbers, it's recommended to use the ReplicatorActivityLevel.IDLE enum member instead of the raw value 3. This makes the code clearer and less prone to errors if the enum values ever change. You'll also need to add ReplicatorActivityLevel to the import statement from cbl-reactnative.
| if (change.status.getActivityLevel() === 3) { // IDLE | |
| if (change.status.getActivityLevel() === ReplicatorActivityLevel.IDLE) { // IDLE |
No description provided.