fix(p3): async file lock for event loop blocking (Issue #763)#794
Open
jlin53882 wants to merge 1 commit into
Open
fix(p3): async file lock for event loop blocking (Issue #763)#794jlin53882 wants to merge 1 commit into
jlin53882 wants to merge 1 commit into
Conversation
P3 修復:runWithFileLock() 的 5 個 sync I/O → async: - existsSync → pathExists() [static async, use access() + constants.F_OK] - mkdirSync → await mkdir() - writeFileSync → await writeFile() - statSync → await stat() - unlinkSync → await unlink() 新增 pathExists() static helper,回傳 Promise<boolean>。 async I/O 不會 block event loop,解決高併發情境下的效能瓶頸。 測試:5/5 通過(pathExists + init + stale check)
This was referenced May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #763 P3: Event Loop Blocking in runWithFileLock()
Convert 5 synchronous I/O calls to async versions to prevent event loop blocking:
Changes
node:fs/promisesimports (access, mkdir, stat, unlink, writeFile)pathExists()static helper (async equivalent of existsSync)Tests
node --test test/p3-async-file-lock.test.mjs # 5/5 tests passedFixes
Checklist