fix(#707): declare allowConversationAccess in plugin manifest 4.24 Version above#777
Closed
jlin53882 wants to merge 2 commits into
Closed
fix(#707): declare allowConversationAccess in plugin manifest 4.24 Version above#777jlin53882 wants to merge 2 commits into
jlin53882 wants to merge 2 commits into
Conversation
Declare allowConversationAccess: true in plugin manifest so non-bundled plugins can use conversation-accessing typed hooks (agent_end, llm_input, llm_output, before_agent_finalize) in OpenClaw 4.24+. Also set hooks.timeouts.before_prompt_build: 60000 (up from the 15s default) to accommodate local ollama + reranker on CPU. Ref: PR#727
…n floor Addresses MR3 from maintainer review: without an engines/peerDependency floor, old OpenClaw versions may silently ignore or reject the allowConversationAccess manifest field. F1 (manifest key missing runtime permission) was already correctly handled by the parent commit.
|
Closing this PR in favor of #755. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題說明
非 bundled 的 OpenClaw 安裝會靜默阻擋 conversation-accessing typed hooks(如
agent_end),導致smartExtraction和memoryReflection永遠不會執行。本 PR 透過在 plugin manifest 宣告所需權限來解決這個問題。修改內容
openclaw.plugin.jsonhooks區塊設定allowConversationAccess: true,讓非 bundled 插件可使用 conversation-accessing hooks(agent_end、llm_input、llm_output、before_agent_finalize)hooks.timeouts.before_prompt_build: 60000(從預設 15s 提高),以支援 local ollama + reranker 在 CPU 上的延遲package.jsonengines.openclaw: ">=4.24.0"宣告最低支援版本下限(回應維護者 MR3 review)回應維護者 Review(PR #727)
allowConversationAccess: true於openclaw.plugin.json的hooks區塊engines.openclaw: ">=4.24.0"before_prompt_buildtimeout 不在 #707 範圍維護者審查修復(延續 PR #727)
已針對 PR #727 審查提出的 Must-Fix 和 Must-Address 問題提交修復 commit:
修改內容
package.json新增engines.openclaw版本下限回應維護者問題
F1 (Must-Fix): Manifest key does not set required runtime hook permission
allowConversationAccess: true已在openclaw.plugin.json的hooks區塊正確設定(parent commit),runtime 讀取路徑是 plugin manifest schema,與engines無直接關聯。MR3 (Must-Address): PR 聲稱 4.24+ 但未宣告版本下限
✅ 已透過
package.json新增engines.openclaw: ">=4.24.0"修復。此欄位會讓舊版 OpenClaw 在安裝插件時得到明確的版本不符警告,而非靜默忽略 manifest 欄位。MR1(
before_prompt_buildtimeout 不在 #707 範圍)理解,該設定為本次 PR 的附帶優化。如需拆分可另開 issue 處理。
MR2(無 runtime 驗證 artifact)
理解,目前無 CI 環境可驗證 OpenClaw 4.24+ runtime 行為,請維護者確認 manifest schema 文件或提供驗證方式。
Build:
fab5da0| Branch:fix/issue707-allow-conversation-access| Original PR: #727