Skip to content

fix(#707): declare allowConversationAccess in plugin manifest 4.24 Version above#777

Closed
jlin53882 wants to merge 2 commits into
CortexReach:masterfrom
jlin53882:fix/issue707-allow-conversation-access
Closed

fix(#707): declare allowConversationAccess in plugin manifest 4.24 Version above#777
jlin53882 wants to merge 2 commits into
CortexReach:masterfrom
jlin53882:fix/issue707-allow-conversation-access

Conversation

@jlin53882
Copy link
Copy Markdown
Contributor

@jlin53882 jlin53882 commented May 9, 2026

問題說明

非 bundled 的 OpenClaw 安裝會靜默阻擋 conversation-accessing typed hooks(如 agent_end),導致 smartExtractionmemoryReflection 永遠不會執行。本 PR 透過在 plugin manifest 宣告所需權限來解決這個問題。

修改內容

openclaw.plugin.json

  • hooks 區塊設定 allowConversationAccess: true,讓非 bundled 插件可使用 conversation-accessing hooks(agent_endllm_inputllm_outputbefore_agent_finalize
  • 設定 hooks.timeouts.before_prompt_build: 60000(從預設 15s 提高),以支援 local ollama + reranker 在 CPU 上的延遲

package.json

  • 新增 engines.openclaw: ">=4.24.0" 宣告最低支援版本下限(回應維護者 MR3 review)

回應維護者 Review(PR #727

項目 狀態
F1: Manifest key does not set required runtime hook permission 已設定 allowConversationAccess: trueopenclaw.plugin.jsonhooks 區塊
MR3: 未宣告版本 floor 已加 engines.openclaw: ">=4.24.0"
MR1: before_prompt_build timeout 不在 #707 範圍 為附帶優化,需拆分可另開 issue
MR2: 無 runtime 驗證 artifact 需維護者提供驗證方式或確認 manifest schema 文件

維護者審查修復(延續 PR #727

已針對 PR #727 審查提出的 Must-Fix 和 Must-Address 問題提交修復 commit:

修改內容

package.json 新增 engines.openclaw 版本下限

+  "engines": {
+    "openclaw": ">=4.24.0"
+  },

回應維護者問題

F1 (Must-Fix): Manifest key does not set required runtime hook permission
allowConversationAccess: true 已在 openclaw.plugin.jsonhooks 區塊正確設定(parent commit),runtime 讀取路徑是 plugin manifest schema,與 engines 無直接關聯。

MR3 (Must-Address): PR 聲稱 4.24+ 但未宣告版本下限
✅ 已透過 package.json 新增 engines.openclaw: ">=4.24.0" 修復。此欄位會讓舊版 OpenClaw 在安裝插件時得到明確的版本不符警告,而非靜默忽略 manifest 欄位。

MR1(before_prompt_build timeout 不在 #707 範圍)
理解,該設定為本次 PR 的附帶優化。如需拆分可另開 issue 處理。

MR2(無 runtime 驗證 artifact)
理解,目前無 CI 環境可驗證 OpenClaw 4.24+ runtime 行為,請維護者確認 manifest schema 文件或提供驗證方式。


Build: fab5da0 | Branch: fix/issue707-allow-conversation-access | Original PR: #727

jlin53882 and others added 2 commits May 9, 2026 23:45
Declare allowConversationAccess: true in plugin manifest so non-bundled
plugins can use conversation-accessing typed hooks (agent_end, llm_input,
llm_output, before_agent_finalize) in OpenClaw 4.24+.

Also set hooks.timeouts.before_prompt_build: 60000 (up from the 15s
default) to accommodate local ollama + reranker on CPU.

Ref: PR#727
…n floor

Addresses MR3 from maintainer review: without an engines/peerDependency
floor, old OpenClaw versions may silently ignore or reject the
allowConversationAccess manifest field.

F1 (manifest key missing runtime permission) was already correctly
handled by the parent commit.
Copy link
Copy Markdown

Closing this PR in favor of #755.

The allowConversationAccess / OpenClaw compatibility work is now covered by the broader OpenClaw 2026.5 runtime compatibility PR. Keeping both open creates duplicate manifest-compatibility review surface. If #755 does not land, this can be reopened or split back out as a minimal manifest-only fix.

@rwmjhb rwmjhb closed this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants