add bge-m3 embedding dimension alias#767
Conversation
|
Please rebase this branch on current The |
d46806d to
1face9d
Compare
rwmjhb
left a comment
There was a problem hiding this comment.
PR #767 Review: add bge-m3 embedding dimension alias
Verdict: APPROVE | 6 rounds completed | Value: 52% | Size: SMALL | Author: TurboTheTurtle
Value Assessment
Problem: Users configuring Huawei/BAAI BGE-M3 with the plain bge-m3 model name hit an unsupported-model startup error unless they set embedding.dimensions; setting dimensions then causes the provider to reject the request. The PR aims to make bge-m3 resolve to the known 1024-dimension default without requiring a dimensions override.
| Dimension | Assessment |
|---|---|
| Value Score | 52% |
| Value Verdict | review |
| Issue Linked | true |
| Project Aligned | true |
| Duplicate | false |
| AI Slop Score | 0/6 |
| User Impact | medium |
| Urgency | medium |
Scope Drift: 2 flag(s)
- index.ts export of
isLayer1CircuitOpenis not justified by the BGE-M3 alias problem statement - test/issue606_sdk-migration.test.mjs jiti loader changes are CI/test-harness related and not mentioned in the PR summary
Open Questions:
- Is
bge-m3already present on current master after this stale branch diverged? - Is exporting
isLayer1CircuitOpenintended as public API, or should the SDK migration test avoid requiring a new export?
Summary
Users configuring Huawei/BAAI BGE-M3 with the plain bge-m3 model name hit an unsupported-model startup error unless they set embedding.dimensions; setting dimensions then causes the provider to reject the request. The PR aims to make bge-m3 resolve to the known 1024-dimension default without requiring a dimensions override.
Evaluation Signals
| Signal | Value |
|---|---|
| Blockers | 0 |
| Warnings | 0 |
| PR Size | SMALL |
| Verdict Floor | approve |
| Risk Level | high |
| Value Model | codex |
| Primary Model | codex |
| Adversarial Model | claude |
Recommended Action
Ready to merge.
Reviewed at 2026-05-12T15:28:01Z | 6 rounds | Value: codex | Primary: codex | Adversarial: claude
Summary
Allow users to configure Huawei/BAAI BGE-M3 with the plain
bge-m3model name without also having to setembedding.dimensionsmanually.bge-m3as a 1024-dimension alias alongside the existingBAAI/bge-m3entry.Fixes #339
Validation
node test/embedder-error-hints.test.mjsgit diff --check