fix(clippy): resolve remaining sort_by and iter_without_into_iter warnings#554
Merged
fix(clippy): resolve remaining sort_by and iter_without_into_iter warnings#554
Conversation
…nings - cortex-prompt-harness/builder.rs: use sort_by_key with Reverse for priority sorting - cortex-tui-input/reader.rs: add IntoIterator impl for &InputReader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the remaining Clippy warnings that were causing CI failures.
Changes
cortex-prompt-harness/src/builder.rs
sort_by(|a, b| b.priority.cmp(&a.priority))tosort_by_key(|s| std::cmp::Reverse(s.priority))cortex-tui-framework/crates/cortex-tui-input/src/reader.rs
IntoIteratorimplementation for&InputReaderto satisfy theiter_without_into_iterlintWhy
These changes address Clippy's
unnecessary_sort_byanditer_without_into_iterlints which are configured as errors (-D warnings) in CI.