fix(clippy): use sort_by_key instead of sort_by for reverse sorting#553
Merged
fix(clippy): use sort_by_key instead of sort_by for reverse sorting#553
Conversation
- Fix cortex-apply-patch backup.rs: use sort_by_key with Reverse - Fix cortex-compact log_pruner.rs: use sort_by_key with Reverse These changes address clippy::unnecessary_sort_by warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Clippy warnings that were treating
sort_bywith a simple comparator as errors.Changes
cortex-apply-patch/src/backup.rs
sort_by(|a, b| b.timestamp.cmp(&a.timestamp))tosort_by_key(|b| std::cmp::Reverse(b.timestamp))cortex-compact/src/auto_compaction/log_pruner.rs
sort_by(|a, b| b.modified.cmp(&a.modified))tosort_by_key(|f| std::cmp::Reverse(f.modified))Why
Clippy's
unnecessary_sort_bylint recommends usingsort_by_keywhen the comparison is simply comparing a single field. This is more idiomatic and can be more efficient.