Skip to content

fix(ci): add libasound2-dev dependency and make audit non-blocking #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
echobt merged 1 commit into from
Feb 2, 2026
Merged

fix(ci): add libasound2-dev dependency and make audit non-blocking #552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
- name: Install Linux dependencies
run: |
sudo apt-get update
sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf libglib2.0-dev
sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf libglib2.0-dev libasound2-dev

- name: Install Rust nightly
uses: dtolnay/rust-toolchain@nightly
Expand Down Expand Up @@ -117,7 +117,7 @@ jobs:
if: matrix.name == 'ubuntu'
run: |
sudo apt-get update
sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf libglib2.0-dev
sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf libglib2.0-dev libasound2-dev

- name: Install Rust nightly
uses: dtolnay/rust-toolchain@nightly
Expand Down Expand Up @@ -165,7 +165,7 @@ jobs:
if: matrix.name == 'ubuntu'
run: |
sudo apt-get update
sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf libglib2.0-dev
sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf libglib2.0-dev libasound2-dev

- name: Install Rust nightly
uses: dtolnay/rust-toolchain@nightly
Expand Down Expand Up @@ -219,7 +219,7 @@ jobs:
if: matrix.name == 'ubuntu'
run: |
sudo apt-get update
sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf libglib2.0-dev
sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf libglib2.0-dev libasound2-dev

- name: Cache npm (Blacksmith 4x faster cache)
uses: actions/cache@v4
Expand Down Expand Up @@ -267,6 +267,9 @@ jobs:
audit:
name: Security Audit
runs-on: blacksmith-4vcpu-ubuntu-2404
# Security audit is informational - don't block CI on known vulnerabilities
# Issues are automatically created for any vulnerabilities found
continue-on-error: true
permissions:
contents: read
issues: write
Expand All @@ -293,13 +296,14 @@ jobs:
steps:
- name: Check all jobs
run: |
# Note: audit job uses continue-on-error, so we don't check it here
# Security vulnerabilities are tracked via GitHub issues instead
if [[ "${{ needs.version-check.result }}" == "failure" || \
"${{ needs.fmt.result }}" == "failure" || \
"${{ needs.clippy.result }}" == "failure" || \
"${{ needs.test.result }}" == "failure" || \
"${{ needs.build-check.result }}" == "failure" || \
"${{ needs.gui-check.result }}" == "failure" || \
"${{ needs.audit.result }}" == "failure" ]]; then
"${{ needs.gui-check.result }}" == "failure" ]]; then
echo "One or more jobs failed"
exit 1
fi
Expand Down
Loading