-
Notifications
You must be signed in to change notification settings - Fork 0
add project description (and update pre-commit config) #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also updated our pre-commit config because the previous version seems to be broken due to the docstring formatting,
👍
I also had to specify an older version of wandb-0.16.0 in requirements.txt that allows to import wandb.wandb_torch, the current one (wandb-0.19.8) does not support this, unfortunately, and the tests fail.
👍
Another issue was caused by AttributeError: np.float_ was removed in the NumPy 2.0 release. Use np.float64 instead. that appeared when running the tests. So, for now I simply added the older version of numpy to requirements.txt, the code works with numpy==1.24.1. Or should I rather update everything to make it work with NumPy 2.0?
no, using numpy<2.0.0 should be fine, upgrading sounds like pain
EDIT: Do we need to remove DFKI-related info from the setup description (i.e. where to find the data on the cluster etc.)?
I would not bother
Important! This repository needs to be made public, so that we can add a working link to it in the paper :)
done
PS: any improvement suggestions, feedback and comments are very welcome!
- There is a command in the readme that uses a script
usrun.shbut I do not see it anywhere. - Would it be possible to mention the commands to execute the actual experiments? Considering the current readme it is not really clear how to reproduce the results from the paper (but maybe I overlooked something).
|
Thanks for the feedback!
Right, I added a short description in the README file.
This is a bit tricky since we had a LOT of different experiments that are quite well documents in both |
This PR adds a brief project description, an illustration of the "probing" workflow and a citation for the current arXiv publication that needs to be updated after the proceedings are out.
I also updated our pre-commit config because the previous version seems to be broken due to the docstring formatting, originally we had docstring v1.4 in
.pre-commit-config.yamlwhich results in the following error message:I also had to specify an older version of wandb-0.16.0 in
requirements.txtthat allows to importwandb.wandb_torch, the current one (wandb-0.19.8) does not support this, unfortunately, and the tests fail.Another issue was caused by
AttributeError: np.float_ was removed in the NumPy 2.0 release. Use np.float64 instead.that appeared when running the tests. So, for now I simply added the older version of numpy torequirements.txt, the code works withnumpy==1.24.1. Or should I rather update everything to make it work with NumPy 2.0?EDIT: Do we need to remove DFKI-related info from the setup description (i.e. where to find the data on the cluster etc.)?
Important! This repository needs to be made public, so that we can add a working link to it in the paper :)
PS: any improvement suggestions, feedback and comments are very welcome!