修复 ControlParticleManager 的内存泄漏问题，以及一处兼容性修改 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harveykang
commented
May 23, 2025
| super.markDead() | ||
| // FIXME 原版的驱逐队列满后不会调用 markDead，百分百泄漏， | ||
| // 我们的 ParticleManagerMixin 可以确保没问题， | ||
| // 但是一旦关闭 ParticleManagerMixin 注入，就绝对有问题 |
Harveykang
commented
May 23, 2025
| * 客户端可视 | ||
| */ | ||
| val clientEmitters = HashMap<UUID, ParticleEmitters>() | ||
| val clientEmitters = ConcurrentHashMap<UUID, ParticleEmitters>() |
Author
There was a problem hiding this comment.
这样可以放到两 tick 之间执行，在 AsyncParticles 那边做的，暂时还没 push 上去
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.