This repository was archived by the owner on Jun 15, 2020. It is now read-only.
Fix contrast.appname #450
Open
Fix contrast.appname #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The -Dcontrast.appname is deprecated, it should be -Dcontrast.standalone.appname or -Dcontrast.override.appname, probably the standalone argument
The -Dcontrast.appname property is deprecated, should be -Dcontrast.override.appname or -Dcontrast.standalone.appname
Changing the appname argument to override.appname or standalone.appname
Changing the appname argument to override.appname or standalone.appname
kaitlynmortimer
requested review from
ElizabethHughes,
ScoRobi and
gilday
and removed request for
ElizabethHughes
evamill
requested review from
evamill
and removed request for
ScoRobi,
kaitlynmortimer and
nahsra
Contributor
|
@sourabhkatti Is this ready to go? @gilday is a reviewer. I am, too. Looks like no one signed off yet, but we'd like to clean up this PR, if possible. Copying @terra4383 |
Contributor
|
We're inconsistently using "standalone" and "override", and we're using the legacy property names instead of the new names. We should always use the new, standalone property. As a system property, it is |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The -Dcontrast.appname property is deprecated, we should change them to -Dcontrast.standalone.appname or -Dcontrast.override.appname, whichever is correct for the situation. I guessed which property would work but someone with more experience with these frameworks should verify my suggestions are correct.