-
Notifications
You must be signed in to change notification settings - Fork 2
MOBILE-16529-Add-examples-for-bottom-sheets-menus-and-dialogs #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOBILE-16529-Add-examples-for-bottom-sheets-menus-and-dialogs #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds example implementations for bottom sheets, menus, and dialogs in the sample app, including UI resources, layouts, fragments, and masking integrations.
- Introduces new strings and menu items for masking/unmasking content
- Adds layouts and fragments for bottom sheet, date/time pickers, and custom alerts
- Updates
SimpleActivitywith buttons, dialog handlers, and ContentSquare masking calls
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Added AI descriptions, menu/dialog labels |
| app/src/main/res/menu/simple_menu.xml | New menu with masked/unmasked items |
| app/src/main/res/layout/fragment_bottom_sheet_dialog.xml | Layout for bottom sheet |
| app/src/main/res/layout/dialog_custom_alert.xml | Layout for custom alert dialog |
| app/src/main/res/layout/activity_simple.xml | Converted to ConstraintLayout and added buttons |
| app/src/main/res/drawable/dialog_background.xml | Shape drawable for custom dialog background |
| app/src/main/java/com/example/androidsampleapp/fragment/TimePickerFragment.kt | Time picker fragment with masking |
| app/src/main/java/com/example/androidsampleapp/fragment/DatePickerFragment.kt | Date picker fragment with masking (interface unused) |
| app/src/main/java/com/example/androidsampleapp/fragment/CustomAlertDialog.kt | Custom alert dialog with masking setup |
| app/src/main/java/com/example/androidsampleapp/fragment/BottomSheetFragment.kt | Bottom sheet fragment implementation |
| app/src/main/java/com/example/androidsampleapp/SimpleActivity.kt | Added menu inflation, masking, button callbacks |
Comments suppressed due to low confidence (2)
app/src/main/res/values/strings.xml:98
- Resource names should use snake_case per Android conventions; consider renaming
contentSquaretocontent_square.
<string name="contentSquare">CSquare</string>
app/src/main/res/layout/activity_simple.xml:12
- [nitpick] XML view IDs should follow snake_case naming for consistency (e.g.,
btn_bottom_sheetsinstead ofbtnBottomSheets).
android:id="@+id/btnBottomSheets"
app/src/main/java/com/example/androidsampleapp/fragment/DatePickerFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/androidsampleapp/fragment/CustomAlertDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/androidsampleapp/fragment/CustomAlertDialog.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!, I've some comments
app/src/main/java/com/example/androidsampleapp/fragment/BottomSheetFragment.kt
Show resolved
Hide resolved
app/src/main/java/com/example/androidsampleapp/fragment/CustomAlertDialog.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/androidsampleapp/fragment/CustomAlertDialog.kt
Show resolved
Hide resolved
app/src/main/java/com/example/androidsampleapp/fragment/DatePickerFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/androidsampleapp/fragment/TimePickerFragment.kt
Outdated
Show resolved
Hide resolved
stefan222
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @kavin-csquare !
ricardo-markiewicz-cs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @kavin-csquare
No description provided.