Skip to content

Conversation

@kavin-csquare
Copy link
Contributor

No description provided.

@kavin-csquare kavin-csquare requested review from Copilot and damir-mazar-cs and removed request for Copilot June 30, 2025 09:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds example implementations for bottom sheets, menus, and dialogs in the sample app, including UI resources, layouts, fragments, and masking integrations.

  • Introduces new strings and menu items for masking/unmasking content
  • Adds layouts and fragments for bottom sheet, date/time pickers, and custom alerts
  • Updates SimpleActivity with buttons, dialog handlers, and ContentSquare masking calls

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
app/src/main/res/values/strings.xml Added AI descriptions, menu/dialog labels
app/src/main/res/menu/simple_menu.xml New menu with masked/unmasked items
app/src/main/res/layout/fragment_bottom_sheet_dialog.xml Layout for bottom sheet
app/src/main/res/layout/dialog_custom_alert.xml Layout for custom alert dialog
app/src/main/res/layout/activity_simple.xml Converted to ConstraintLayout and added buttons
app/src/main/res/drawable/dialog_background.xml Shape drawable for custom dialog background
app/src/main/java/com/example/androidsampleapp/fragment/TimePickerFragment.kt Time picker fragment with masking
app/src/main/java/com/example/androidsampleapp/fragment/DatePickerFragment.kt Date picker fragment with masking (interface unused)
app/src/main/java/com/example/androidsampleapp/fragment/CustomAlertDialog.kt Custom alert dialog with masking setup
app/src/main/java/com/example/androidsampleapp/fragment/BottomSheetFragment.kt Bottom sheet fragment implementation
app/src/main/java/com/example/androidsampleapp/SimpleActivity.kt Added menu inflation, masking, button callbacks
Comments suppressed due to low confidence (2)

app/src/main/res/values/strings.xml:98

  • Resource names should use snake_case per Android conventions; consider renaming contentSquare to content_square.
    <string name="contentSquare">CSquare</string>

app/src/main/res/layout/activity_simple.xml:12

  • [nitpick] XML view IDs should follow snake_case naming for consistency (e.g., btn_bottom_sheets instead of btnBottomSheets).
        android:id="@+id/btnBottomSheets"

Copy link
Contributor

@ricardo-markiewicz-cs ricardo-markiewicz-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!, I've some comments

Copy link
Contributor

@stefan222 stefan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kavin-csquare !

Copy link
Contributor

@ricardo-markiewicz-cs ricardo-markiewicz-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kavin-csquare

@kavin-csquare kavin-csquare merged commit 7728544 into master Jul 4, 2025
1 check passed
@kavin-csquare kavin-csquare deleted the MOBILE-16529-Add-examples-for-bottom-sheets-menus-and-dialogs branch July 4, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants