Add batch delete function of security group rule.#1314
Open
DarkFrank wants to merge 1 commit intoContainX:masterfrom
Open
Add batch delete function of security group rule.#1314DarkFrank wants to merge 1 commit intoContainX:masterfrom
DarkFrank wants to merge 1 commit intoContainX:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using security groups to implement the whitelist feature, which requires delete security group rules in batches but is not implemented in openstack 4J, so submit the request.If there are any deficiencies, please correct them, thanks.
In addition, I found that there were no unit tests related to the safety group rules, which I would add if have free time.