[v4] Staging #45
Open
[v4] Staging #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
module test files tmp clangd copy over presets formatting interface -> public use toolchain xcrun apple gated bump error comments tmp workflow preset use toolchain naive ctest use alises use a module move to src add libfiles add project call to tests gh action ubuntu mirror casing downgrade to warn Revert "downgrade to warn" This reverts commit 90d9360. no prefix path rm umbuntu workflow lints fix spelling no bundle deps correct version test a linux gcc build rm bundle try ninja in path reoder just lower case rm dead variable Revert "just lower case" This reverts commit 351abe4. Revert "reoder" This reverts commit 366acd5. tmp re-order the other way move back to legacy unify dont specify versions versioned
ConorWilliams
force-pushed
the
modules
branch
from
d006523 to
995c92f
Compare
* squash use catch2 for testing add catch2 to CI overall structure * squash multi configuration ci tmp add nm tmp --remove if no work Revert "tmp --remove if no work" This reverts commit d643bf3. dev flow move to dev presets dont ignore rm ci workflows spell add required add required more flags for debug * linear history CI * more warnings * more flags * names * Basic sanitize * check if defined * warning flags * add test/build * add to ci * revert linux santize (ICE)
* mv license * same checkout version * move to frame * casting checks * cmake for benchmark * fib * add benchmark dep * new benchmark structure * pragma once on headers * version test * better version test * add src * strip prefix * bench preset * benchmark as a test * add benchmark test to preset * move to todo * use variables * drop no plt * rename * proper fib benchmark * drop todo * spell * macros * no-except safe * even better errors * exception safe * Resolve review comments: add include guard, fix macro evaluations, improve error messages Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com> * Complete review comment resolution Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com> * Add CodeQL symlink to .gitignore Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com> * Update .gitignore * Add Fibonacci serial benchmark with direct return Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com> * Complete: Add Fibonacci serial benchmark with direct return Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com> * Remove CodeQL artifact and update gitignore Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com> * Fix .gitignore formatting Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com> * Remove doxygen-specific bits from macros.hpp Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com> * Complete removal of doxygen-specific bits Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com> * undo _codeql shenanigens * reoder bench naming convention * shorten * macros * prevent loop invariant lifting * spell * use do-not opt for basic fib as well
* macros + format * add benchmark to lint * agents.md * tweaks to agents.md * fix typos * add .gemini * hide banner * Update .clang-format Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix comment --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ConorWilliams
force-pushed
the
modules
branch
from
0808139 to
1e44af0
Compare
* explicit casts * add concpets and task * primatives in promise * instanciate * use coroutine fib * golf * split up macros * use split macros * rename * move common to fib * tweak clang tidy * impl terminate_with * drop unused * break out frame * utiliy types * formatting * wip * utility tests * task immovable * rename test * drop test form bench preset * add sym transfer * add more assume * disable false +ve lint * movable task * golf * assume * alloc policy structure * more alloc policy * inherit from policy * add dummy * initial test * constants * sized delete * renames * bump * use thread local * new assert * fix assume * protect macro * fix macro typo * typo * rm bad comment * add to file set
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A work in progress of the next version of libfork, this PR will contains squashes of sub-PRs
Before merging to main: