feat: activate ConceptOrganisaties dashboard widget with shared chunks#215
Merged
rubenvdlinde merged 1 commit intodevelopmentfrom May 5, 2026
Merged
Conversation
Wire up the previously orphaned ConceptOrganisaties widget by registering it in Application.php. Widget previously had load() + Vue mount but was never exposed to the dashboard. Also bring the bundle in line with the org-wide ADR-004 pattern: - splitChunks emits softwarecatalog-shared-vendor.js (vue/pinia/icons) and softwarecatalog-shared-nc-vue.js (@nextcloud/vue + @conduction/nextcloud-vue) - runtimeChunk emits softwarecatalog-runtime.js for cross-chunk module resolution - Widget load() attaches runtime + vendor + nc-vue + widget chunks in order - Drops the unused ts-loader rule (0 .ts files in src/) Bumps appinfo version 0.1.140 → 0.1.141 to bust the Nextcloud script cache.
Contributor
Quality Report — ConductionNL/softwarecatalog @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 120/120 | |||
| npm | ❌ | ❌ | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-05 09:15 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/AppInfo/Application.php. The widget already had a Vue mount andload()method but was never exposed to the dashboard.splitChunksemitssoftwarecatalog-shared-vendor.js+softwarecatalog-shared-nc-vue.js,runtimeChunkemitssoftwarecatalog-runtime.js, widgetload()attaches runtime → vendor → nc-vue → widget in order.ts-loaderrule (0.tsfiles undersrc/).0.1.140→0.1.141so Nextcloud invalidates the cached widget script.Test plan